Skip to content

server: add duplicate host check on addHost#13177

Draft
shwstppr wants to merge 1 commit into
apache:4.20from
shapeblue:add-duplicate-host-check
Draft

server: add duplicate host check on addHost#13177
shwstppr wants to merge 1 commit into
apache:4.20from
shapeblue:add-duplicate-host-check

Conversation

@shwstppr
Copy link
Copy Markdown
Contributor

Description

Fixes #13080

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Fixes apache#13080

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
@codecov
Copy link
Copy Markdown

codecov Bot commented May 18, 2026

Codecov Report

❌ Patch coverage is 71.42857% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 16.26%. Comparing base (a7c2a05) to head (bbc65d0).

Files with missing lines Patch % Lines
...n/java/com/cloud/resource/ResourceManagerImpl.java 71.42% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               4.20   #13177      +/-   ##
============================================
- Coverage     16.27%   16.26%   -0.01%     
+ Complexity    13440    13435       -5     
============================================
  Files          5665     5665              
  Lines        500555   500569      +14     
  Branches      60789    60791       +2     
============================================
- Hits          81445    81427      -18     
- Misses       410004   410034      +30     
- Partials       9106     9108       +2     
Flag Coverage Δ
uitests 4.15% <ø> (ø)
unittests 17.12% <71.42%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@shwstppr shwstppr changed the title server: add duplicate host check server: add duplicate host check on addHost May 18, 2026
@shwstppr shwstppr requested a review from Copilot May 18, 2026 08:27
@shwstppr
Copy link
Copy Markdown
Contributor Author

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@blueorangutan
Copy link
Copy Markdown

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 17889

@shwstppr shwstppr linked an issue May 18, 2026 that may be closed by this pull request
@shwstppr
Copy link
Copy Markdown
Contributor Author

Closign in favor #13182 as @vishesh92 has created his own solution now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Don't allow adding an existing KVM host to another zone

3 participants