Add Guest OS mapping for windows server 2025 on VMware by Pearl1594 · Pull Request #12358 · apache/cloudstack

Pearl1594 · 2025-12-31T16:50:25Z

Description

This PR adds guest os and mappings for Windows Server 2025
Addresses: #12324
Deployed a new virtual machine on vmware 8.0.3 and set the guest os to Windows server 2025 and found the mapping

on ESXi host - the guest os it guest mapped to is windows2022srvNext_64Guest

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
Build/CI
Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

VM OS Type

ISO registered with OS type Windows Server 2025:

How did you try to break this feature and the system with this change?

codecov · 2025-12-31T16:57:01Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 18.10%. Comparing base (6b831f5) to head (e6544c4).
⚠️ Report is 17 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff            @@
##               main   #12358   +/-   ##
=========================================
  Coverage     18.10%   18.10%           
- Complexity    16742    16745    +3     
=========================================
  Files          6037     6037           
  Lines        542887   542887           
  Branches      66480    66480           
=========================================
+ Hits          98279    98289   +10     
+ Misses       433561   433551   -10     
  Partials      11047    11047

Flag	Coverage Δ
uitests	`3.51% <ø> (ø)`
unittests	`19.26% <ø> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

sonarqubecloud · 2025-12-31T17:49:45Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Pearl1594 · 2026-01-02T19:03:19Z

@blueorangutan package

blueorangutan · 2026-01-02T19:04:04Z

@Pearl1594 a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2026-01-02T20:07:56Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 16233

DaanHoogland

clgtm, but should this not go on earlier versions than 23?

github-actions · 2026-01-05T08:42:52Z

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

shwstppr

LGTM

shwstppr · 2026-01-07T06:25:13Z

 UPDATE `cloud`.`configuration` SET value='firstfit' WHERE name IN ('vm.allocation.algorithm', 'volume.allocation.algorithm') AND value='userconcentratedpod_firstfit';
+
+-- Add Windows Server 2025 guest OS and mappings
+CALL ADD_GUEST_OS_AND_HYPERVISOR_MAPPING (6, 'Windows Server 2025 (64-bit)', 'VMware', '7.0', 'windows2022srvNext_64Guest');


At some point we should stop using constant category IDs as they are dynamic now

today is a good day to die… ;)

weizhouapache

code lgtm

this is a minor guest os support, can we move to schema-42200to42210.sql ?

shwstppr · 2026-01-28T05:01:21Z

@Pearl1594 can you please address the conflicts?

weizhouapache · 2026-05-11T09:00:23Z

@Pearl1594
is this applicable for 4.23 ?

kiranchavala · 2026-05-22T09:00:03Z

@Pearl1594 can you resolve the conflicts , will test it for the 4.23 release

Hitting the issue on the recent 4.22

…025-vmware-os-mapping

Pearl1594 · 2026-05-22T13:15:55Z

I believe this could still be relevant @weizhouapache .
Updated the PR @kiranchavala

Pearl1594 · 2026-05-22T13:22:51Z

@blueorangutan package

blueorangutan · 2026-05-22T13:24:04Z

@Pearl1594 a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2026-05-22T14:06:59Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 17992

sonarqubecloud · 2026-05-22T14:09:50Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Add Guest OS mapping for windows server 2025 on VMware

f7f2655

Pearl1594 requested a review from DaanHoogland December 31, 2025 16:50

Pearl1594 marked this pull request as ready for review January 2, 2026 19:03

DaanHoogland approved these changes Jan 5, 2026

View reviewed changes

github-actions Bot added the status:has-conflicts label Jan 5, 2026

sureshanaparti linked an issue Jan 6, 2026 that may be closed by this pull request

Windows Server 2025 ISO VM maps as “Other” OS type in vCenter on CloudStack 4.21 (VMware 8.0.3) #12324

Open

shwstppr approved these changes Jan 7, 2026

View reviewed changes

shwstppr reviewed Jan 7, 2026

View reviewed changes

weizhouapache approved these changes Jan 7, 2026

View reviewed changes

winterhazel added this to the 4.23.0 milestone Feb 3, 2026

Merge branch 'main' of https://github.com/apache/cloudstack into win2…

e6544c4

…025-vmware-os-mapping

github-actions Bot removed the status:has-conflicts label May 22, 2026

Conversation

Pearl1594 commented Dec 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Uh oh!

codecov Bot commented Dec 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

sonarqubecloud Bot commented Dec 31, 2025

Quality Gate passed

Uh oh!

Pearl1594 commented Jan 2, 2026

Uh oh!

blueorangutan commented Jan 2, 2026

Uh oh!

blueorangutan commented Jan 2, 2026

Uh oh!

DaanHoogland left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Jan 5, 2026

Uh oh!

shwstppr left a comment

Choose a reason for hiding this comment

Uh oh!

shwstppr Jan 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

DaanHoogland Jan 7, 2026

Choose a reason for hiding this comment

Uh oh!

weizhouapache left a comment

Choose a reason for hiding this comment

Uh oh!

shwstppr commented Jan 28, 2026

Uh oh!

weizhouapache commented May 11, 2026

Uh oh!

kiranchavala commented May 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Pearl1594 commented May 22, 2026

Uh oh!

Pearl1594 commented May 22, 2026

Uh oh!

blueorangutan commented May 22, 2026

Uh oh!

blueorangutan commented May 22, 2026

Uh oh!

sonarqubecloud Bot commented May 22, 2026

Quality Gate passed

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Pearl1594 commented Dec 31, 2025 •

edited

Loading

codecov Bot commented Dec 31, 2025 •

edited

Loading

shwstppr Jan 7, 2026 •

edited

Loading

kiranchavala commented May 22, 2026 •

edited

Loading