Conversation
|
Will review it later. Thanks! |
|
Hi, I've opened an issue regarding the container workflow: #1687. This appears to be a common limitation within the ASF, and I'll address it as soon as possible. |
There was a problem hiding this comment.
Pull request overview
Adds Rocky Linux 10 Docker build/test container definitions (based on Rocky9) and wires them into CI so images are built and validated.
Changes:
- Add Rocky10 build container (Dockerfile, configs, TestInfra tests, requirements).
- Add Rocky10 test container (Dockerfile and runtime init/configs).
- Update GitHub Actions workflows and RAT exclusions to include the Rocky10 paths.
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
pom.xml |
Excludes Rocky10 test requirements file from RAT checks. |
devops/deploy/docker/test/rocky10/Dockerfile |
New Rocky10 “test environment” container image definition. |
devops/deploy/docker/test/rocky10/configs/init_system.sh |
Container init script for Rocky10 test environment (SSH, dirs, banner). |
devops/deploy/docker/test/rocky10/configs/gpinitsystem.conf |
gpinitsystem config for initializing a demo cluster in the test container. |
devops/deploy/docker/test/rocky10/configs/90-cbdb-limits |
Adds limits configuration for gpadmin in Rocky10 test container. |
devops/deploy/docker/build/rocky10/Dockerfile |
New Rocky10 “build environment” container image definition incl. xerces + Go install. |
devops/deploy/docker/build/rocky10/configs/init_system.sh |
Container init script for Rocky10 build environment (SSH, banner). |
devops/deploy/docker/build/rocky10/configs/gpinitsystem.conf |
gpinitsystem config included with Rocky10 build image. |
devops/deploy/docker/build/rocky10/configs/90-cbdb-limits |
Adds limits configuration for gpadmin in Rocky10 build container. |
devops/deploy/docker/build/rocky10/tests/testinfra/test_cloudberry_db_env.py |
TestInfra validation for Rocky10 build image packages and basic config. |
devops/deploy/docker/build/rocky10/tests/requirements.txt |
Python test dependencies list for Rocky10 build image tests. |
.github/workflows/docker-cbdb-test-containers.yml |
Adds rocky10 to matrix and path filters for test containers. |
.github/workflows/docker-cbdb-build-containers.yml |
Adds rocky10 to matrix and path filters for build containers. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This is the copy or Rocky9 containers. Changes comparing to Rocky9: - Get rid here of packages not available right now under Rocky10 repositories (for example rocky-release-hpc) - Move to the Java 21, it's default to Rocky Linux 10
|
When running the configure script: But it seems the Actually, the line is the 187 in configure-cloudberry.sh: |
But it's not a blocker to build the Cloudberry from source. FYI. |
tuhaihe
left a comment
There was a problem hiding this comment.
LGTM. Thanks for your great work!
Changes:
This is the copy or Rocky9 containers.
What I've changed comparing to Rocky9:
Get rid here of packages not available right now under Rocky10 repositories (for example rocky-release-hpc)
Move to the Java 21, it's now default for Rocky linux 10