Fix assertion if index is dropped during REFRESH CONCURRENTLY#1632
Open
reshke wants to merge 2 commits intoapache:mainfrom
Open
Fix assertion if index is dropped during REFRESH CONCURRENTLY#1632reshke wants to merge 2 commits intoapache:mainfrom
reshke wants to merge 2 commits intoapache:mainfrom
Conversation
x4m
approved these changes
Mar 21, 2026
avamingli
approved these changes
Mar 23, 2026
Contributor
avamingli
left a comment
avamingli
left a comment
There was a problem hiding this comment.
Thanks for cherry-pick.
reshke
force-pushed
the
cp_a45c950ae35e53de40_main
branch
2 times, most recently
from
fb20573 to
f893f35
Compare
Contributor
|
matview tests failed with |
my-ship-it
approved these changes
Mar 30, 2026
Contributor
my-ship-it
left a comment
my-ship-it
left a comment
There was a problem hiding this comment.
Overall the code changes are solid upstream backports. LGTM!
When assertions are disabled, the built SQL statement is invalid and you get a "syntax error". So this isn't a serious problem, but let's avoid the assertion failure. Backpatch to all supported versions. Reviewed-by: Noah Misch
reshke
force-pushed
the
cp_a45c950ae35e53de40_main
branch
from
f893f35 to
eea4f51
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When assertions are disabled, the built SQL statement is invalid and you get a "syntax error". So this isn't a serious problem, but let's avoid the assertion failure.
Backpatch to all supported versions.
Reviewed-by: Noah Misch
======
In CBDB, we backport this change for future-proofing and in sight of d42418a and general backporting of all security-related changes.