Fix pip ResolutionTooDeep#39017
Conversation
edb2827 to
e7232f5
Compare
|
Run TFT Criteo Benchmarks |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses recurring dependency resolution issues in the CloudML benchmark environment. By introducing a formal constraints file and updating dependency specifications in the requirements file, the build process is now more robust and less prone to complex resolution failures during package installation. Highlights
New Features🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a constraints file (constraints.txt) to pin dependency versions for CloudML benchmarks, helping to avoid pip ResolutionTooDeep errors. It also updates requirements.txt with adjusted version bounds and simplifies the installation step in common.gradle to use this constraints file. The review feedback suggests documenting the usage of the constraints file within requirements.txt and adding a pin for tensorflow-serving-api in constraints.txt for completeness.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| tfx_bsl==1.16.1 | ||
| tensorflow-transform==1.16.0 | ||
| tensorflow>=2.16,<2.17 | ||
| # Core TFT dependencies with version bounds |
There was a problem hiding this comment.
To prevent developers or automated scripts from hitting ResolutionTooDeep errors when installing these requirements directly, it is highly recommended to document that the constraints file should be used.
# Core TFT dependencies with version bounds.\n# Note: To avoid pip ResolutionTooDeep errors, always install using the constraints file:\n# pip install -c constraints.txt -r requirements.txt
There was a problem hiding this comment.
Could you add this comment please?
| # TensorFlow ecosystem | ||
| tensorflow==2.15.1 | ||
| tensorflow-metadata==1.15.0 | ||
| tf-keras==2.15.1 |
There was a problem hiding this comment.
For completeness and to ensure consistent resolution of all TensorFlow ecosystem packages, consider pinning tensorflow-serving-api in the constraints file as well, since it is specified in requirements.txt.
# TensorFlow ecosystem\ntensorflow==2.15.1\ntensorflow-metadata==1.15.0\ntf-keras==2.15.1\ntensorflow-serving-api==2.15.1
|
Assigning reviewers: R: @damccorm for label python. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
damccorm
left a comment
There was a problem hiding this comment.
Thanks - this generally LGTM, just had one comment
| tfx_bsl==1.16.1 | ||
| tensorflow-transform==1.16.0 | ||
| tensorflow>=2.16,<2.17 | ||
| # Core TFT dependencies with version bounds |
There was a problem hiding this comment.
Could you add this comment please?
Fixes: #38780
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.