[Dataflow Streaming] Access state/timerinternals via StepContext#38991
[Dataflow Streaming] Access state/timerinternals via StepContext#38991arunpandianp wants to merge 2 commits into
Conversation
|
R: @scwhittle |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request improves the safety of state and timer management in Dataflow streaming by decoupling DoFnRunners from direct references to state and timer internals. By requiring access through StepContext, the system ensures that components always retrieve the correct, active internals for the current key. Additionally, a defensive 'poisoning' mechanism was introduced to detect and prevent illegal stale access to these internals after the bundle processing is complete. Highlights
New Features🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors LateDataDroppingDoFnRunner to accept StepContext instead of TimerInternals and introduces a mechanism to "poison" state and timer internals (WindmillStateInternals and WindmillTimerInternals) after flushState() to prevent stale usage. The review feedback suggests adding a defensive null check for stepContext in LateDataFilter and declaring the poisoned flags as volatile in both WindmillTimerInternals and WindmillStateInternals to ensure proper thread visibility.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
2 participants
Change LateDataDroppingDoFnRunner to not use state and timer internals directly. The state/timerinternals change when keys change in a multi key bundle and it is not safe for DoFnRunners to cache them for the entire bundle.
Added a mechanism to poison WindmillStateInternals and WindmillTimerInternals which will help catch any such caching in future.
StatefulDoFnRunner also caches state and timer internals directly, but it is not used by dataflow, so I didn't include them in this change.