Skip to content

fix main: parquet test compilation failure#10266

Merged
alamb merged 1 commit into
apache:mainfrom
Jefffrey:fix-main
Jul 2, 2026
Merged

fix main: parquet test compilation failure#10266
alamb merged 1 commit into
apache:mainfrom
Jefffrey:fix-main

Conversation

@Jefffrey

@Jefffrey Jefffrey commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

audit failing

Crate:     quick-xml
Version:   0.39.3
Title:     Unbounded namespace-declaration allocation in `NsReader` enables memory-exhaustion denial of service
Date:      2026-06-29
ID:        RUSTSEC-2026-0195
URL:       https://rustsec.org/advisories/RUSTSEC-2026-0195
Severity:  7.5 (high)
Solution:  Upgrade to >=0.41.0

parquet test failing

error[E0061]: this function takes 6 arguments but 5 arguments were supplied
   --> parquet/src/arrow/arrow_reader/read_plan.rs:544:20
    |
544 |         let leaf = make_int32_page_reader(&data, &levels, &levels, 0, 0);
    |                    ^^^^^^^^^^^^^^^^^^^^^^------------------------------- argument #6 of type `Option<i16>` is missing
    |
note: function defined here
   --> parquet/src/arrow/array_reader/test_util.rs:102:8
    |
102 | pub fn make_int32_page_reader(
    |        ^^^^^^^^^^^^^^^^^^^^^^
...
108 |     padding_threshold: Option<i16>,
    |     ------------------------------
help: provide the argument
    |
544 |         let leaf = make_int32_page_reader(&data, &levels, &levels, 0, 0, /* Option<i16> */);
    |                                                                        +++++++++++++++++++

error[E0061]: this function takes 6 arguments but 5 arguments were supplied
   --> parquet/src/arrow/arrow_reader/read_plan.rs:550:29
    |
550 |         let struct_reader = StructArrayReader::new(struct_type, vec![leaf], 0, 0, false);
    |                             ^^^^^^^^^^^^^^^^^^^^^^-------------------------------------- argument #6 of type `Option<i16>` is missing
    |
note: associated function defined here
   --> parquet/src/arrow/array_reader/struct_array.rs:42:12
    |
 42 |     pub fn new(
    |            ^^^
...
 48 |         padding_threshold: Option<i16>,
    |         ------------------------------
help: provide the argument
    |
550 |         let struct_reader = StructArrayReader::new(struct_type, vec![leaf], 0, 0, false, /* Option<i16> */);
    |                                                                                        +++++++++++++++++++

@github-actions github-actions Bot added the parquet Changes to the parquet crate label Jul 2, 2026
@Jefffrey Jefffrey changed the title fix main (parquet test compilation + quick-xml version bump) fix main: parquet test compilation failure Jul 2, 2026
@Jefffrey

Jefffrey commented Jul 2, 2026

Copy link
Copy Markdown
Contributor Author

hm i guess object store needs to bump for quick-xml 🤔

@Jefffrey Jefffrey requested a review from alamb July 2, 2026 11:56
@alamb

alamb commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Thank you

@alamb

alamb commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

QuickXML looks like we will need to wait for the object store release

@alamb alamb merged commit d969025 into apache:main Jul 2, 2026
18 of 19 checks passed
@Jefffrey Jefffrey deleted the fix-main branch July 2, 2026 12:59
@alamb

alamb commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

PR to fix audit failure: #10267

@alamb

alamb commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

The test failure is likely due to a logical conflict introduced by #9848

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

parquet Changes to the parquet crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants