create dictionary reader config and default unsafeflag to false#10260
Open
Rich-T-kid wants to merge 2 commits into
Open
create dictionary reader config and default unsafeflag to false#10260Rich-T-kid wants to merge 2 commits into
Rich-T-kid wants to merge 2 commits into
Conversation
1be94a0 to
82fd3b8
Compare
Contributor
Author
|
Two approaches are split between the two commits commit #1: Introduce a new struct that holds commit #2: expose I'm happy to go with either approach depending on what the maintainers think is more appropriate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
FlightDataDecoder.skip_validationdoes not get propagated toarrow_ipc::reader::read_dictionary(), the flag is hardcoded to false. This causes validation checks even when this isn't what the caller wants.What changes are included in this PR?
commit #/1:
arrow_ipc::reader::DictionaryConfigthats holds the message version as well as theunsafeFlagDictionaryConfigcontains a builder method to setskip_validationthis gets passed intoread_dictionary_implfor readsAre these changes tested?
yes.
Are there any user-facing changes?
view #10260 (comment)