Skip to content

create dictionary reader config and default unsafeflag to false#10260

Open
Rich-T-kid wants to merge 2 commits into
apache:mainfrom
Rich-T-kid:rich-T-kid/propogate-unsafe-bool-flag-dictionary
Open

create dictionary reader config and default unsafeflag to false#10260
Rich-T-kid wants to merge 2 commits into
apache:mainfrom
Rich-T-kid:rich-T-kid/propogate-unsafe-bool-flag-dictionary

Conversation

@Rich-T-kid

@Rich-T-kid Rich-T-kid commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Which issue does this PR close?

Rationale for this change

FlightDataDecoder.skip_validation does not get propagated to arrow_ipc::reader::read_dictionary(), the flag is hardcoded to false. This causes validation checks even when this isn't what the caller wants.

What changes are included in this PR?

commit #/1:

Are these changes tested?

yes.

Are there any user-facing changes?

view #10260 (comment)

@github-actions github-actions Bot added arrow Changes to the arrow crate arrow-flight Changes to the arrow-flight crate labels Jul 1, 2026
@Rich-T-kid Rich-T-kid force-pushed the rich-T-kid/propogate-unsafe-bool-flag-dictionary branch from 1be94a0 to 82fd3b8 Compare July 1, 2026 23:47
@Rich-T-kid

Copy link
Copy Markdown
Contributor Author

Two approaches are split between the two commits

commit #1: Introduce a new struct that holds metadata_version as well as the unsafeFlag. pass this to arrow-ipc::reader::read_dictionary(). this would be a breaking API change

commit #2: expose arrow_ipc::reader::read_dictionary_impl directly so that the unsafe flag can be called directly. this is not a breaking API change

I'm happy to go with either approach depending on what the maintainers think is more appropriate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

arrow Changes to the arrow crate arrow-flight Changes to the arrow-flight crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Flight skip_validation should apply to dictionary batches

1 participant