Add validated row decode benchmark#10259
Open
alamb wants to merge 1 commit into
Open
Conversation
alamb
force-pushed
the
codex/bench-validated-row-decode
branch
from
345e692 to
d972932
Compare
alamb
commented
Jul 1, 2026
| .collect(); | ||
| c.bench_function(&format!("convert_rows_validated {name}"), |b| { | ||
| b.iter(|| { | ||
| hint::black_box( |
Contributor
Author
There was a problem hiding this comment.
I profiled these benchmarks locally and the profile looks reasonable to me (it is validating the parsed rows)
Jefffrey
reviewed
Jul 2, 2026
Jefffrey
left a comment
Jefffrey
left a comment
Contributor
There was a problem hiding this comment.
this is a good catch; didn't realize we needed this roundabout way of enabling validation
one concern i have here is this will add this new bench for non-string types creating more benchmark noise (and i think it ignores nulls too so the null config benches also get extra noise because of this)
probably want to config this so it only runs for string types (and probably just for the 0.0 null density case) 🤔
| // back into Arrow arrays by RowConverter::convert_rows. | ||
| let parsed_rows: Vec<_> = binary_rows | ||
| .iter() | ||
| .flatten() |
Contributor
There was a problem hiding this comment.
does this mean nulls are ignored in this bench?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
The existing row format benchmark measures
convert_rowsusing rows created directly byRowConverter::convert_columns, which skips UTF-8 validation during decode.What changes are included in this PR?
This adds a
convert_rows_validatedbenchmark that decodes rows parsed throughRowParser, exercising the UTF-8 validation path. It also derivesCloneforRowsso the benchmark setup can reuse the prepared rows when converting to binary.Are these changes tested?
CI.
I also ran it locally like
Are there any user-facing changes?
No breaking changes.
Rowsnow implementsClone.