deprecate flight_data_to_arrow_batch#10256
Open
Rich-T-kid wants to merge 1 commit into
Open
Conversation
github-actions
Bot
added
arrow
Contributor
Author
|
closes #10249 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
after #10206
flight_to_arrow_batchwas only used in one location, within a test function. It served as a thin wrapper overread_record_batch. since #10206 maderead_record_batchpublic callers should just call it directlyWhat changes are included in this PR?
flight_data_to_arrow_batchto callarrow_ipc::reader::read_record_batchdirectly, and marks the function as deprecated since 59.1.0 pointing callers to do the same.Are these changes tested?
yes. the changes are to test
Are there any user-facing changes?
yes, users will now receive a deprecated warning, guiding them to use
read_record_batch()directly