Bump MSRV to 1.88#10254
Open
alamb wants to merge 7 commits into
Open
Conversation
github-actions
Bot
added
parquet
alamb
commented
Jul 1, 2026
| n.len(), | ||
| ))); | ||
| } | ||
| if let Some(n) = nulls.as_ref() |
Contributor
Author
There was a problem hiding this comment.
Updating MSRV requires updating clippy as well
| "encountered non UTF-8 data".to_string(), | ||
| )); | ||
| } | ||
| if validate_utf8 && let Some(&b) = data.first() { |
Contributor
Author
There was a problem hiding this comment.
this is all basically driven by the introduction of let chains
| ] | ||
| edition = "2024" | ||
| rust-version = "1.85" | ||
| rust-version = "1.88" |
Contributor
Author
There was a problem hiding this comment.
This is the main change of this PR
alamb
added
next-major-release
Jefffrey
reviewed
Jul 2, 2026
Jefffrey
left a comment
Jefffrey
left a comment
Contributor
There was a problem hiding this comment.
also found this note in the codebase which could also be resolved in this PR
arrow-rs/arrow-select/src/dictionary.rs
Lines 81 to 92 in 32bba5a
Co-authored-by: Jeffrey Vo <jeffrey.vo.australia@gmail.com>
…p-msrv-1-88 # Conflicts: # parquet/src/arrow/arrow_writer/mod.rs
Contributor
Author
in c92f581 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
This implements the suggestion from #10226 (comment) to bump the MSRV from Rust 1.85 to Rust 1.88 for the next major release.
What changes are included in this PR?
std::mem::transmuteworkarounds inarrow-arraythat were only needed because constf32::from_bitsandf64::from_bitswere unavailable under the previous MSRV.Are there any user-facing changes?
Users building arrow-rs crates will need Rust 1.88 or newer.
How was this tested?
CI