feat: support uuid from fixed type of length 16#10241
Open
ariel-miculas wants to merge 2 commits into
Open
Conversation
github-actions
Bot
added
arrow
Jefffrey
reviewed
Jun 30, 2026
Comment on lines
1555
to
+1569
| Some("duration") => { | ||
| if size != 12 { | ||
| return Err(ArrowError::ParseError(format!( | ||
| "Invalid fixed size for Duration: {size}, must be 12" | ||
| ))); | ||
| }; | ||
| AvroDataType { | ||
| nullability: None, | ||
| metadata, | ||
| codec: Codec::Interval, | ||
| resolution: None, | ||
| } | ||
| } | ||
| Some("uuid") if size == 16 => { | ||
| metadata.insert("logicalType".into(), "uuid".into()); |
Contributor
There was a problem hiding this comment.
Is there significance to duration above error checking the size, whilst for uuid we silently pass to the catchall below?
Contributor
Author
There was a problem hiding this comment.
no, it's better to return an error, I'll update it
Jefffrey
approved these changes
Jul 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Related to #8703
Rationale for this change
In version 1.12.0 of the spec, uuid is allowed to be either an Avro string or fixed of length 16.
What changes are included in this PR?
Are these changes tested?
Added a unit test
Are there any user-facing changes?
The uuid logical type is inserted into the arrow Field metadata if the uuid logical type is present as a logical annotation on the avro type.