MINOR: Fix Gandiva JNI build against Arrow C++ 24.0.0#1140
Open
jbonofre wants to merge 5 commits intoapache:mainfrom
Open
MINOR: Fix Gandiva JNI build against Arrow C++ 24.0.0#1140jbonofre wants to merge 5 commits intoapache:mainfrom
jbonofre wants to merge 5 commits intoapache:mainfrom
Conversation
arrow::decimal() was removed in Arrow C++ 24.0.0; replace with arrow::decimal128().
lidavidm
approved these changes
May 7, 2026
Arrow C++ 24.0.0 introduced xsimd >= 14.0.0 as a required dependency. The base Docker image was built for an older Arrow C++ release and does not have xsimd pre-installed, causing the Linux JNI cmake configuration to fail. Explicitly install it via vcpkg before the cmake step.
The xsimd installation via vcpkg was not visible to CMake because the vcpkg toolchain file was not passed to the Arrow C++ configure step.
The Docker image's vcpkg registry only has xsimd 13.2.0 but Arrow C++ 24.0.0 requires >= 14.0.0. Override xsimd_SOURCE=BUNDLED so Arrow downloads and uses xsimd 14.0.0 directly.
kou
reviewed
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Arrow C++ 24.0.0 introduced two breaking changes for the JNI build:
arrow::decimal()was removed; replaced witharrow::decimal128()in the Gandiva JNI source.xsimd >= 14.0.0 is now a required dependency. The Docker image's vcpkg registry only ships xsimd 13.2.0, so the Linux JNI CMake configuration was failing. Fixed by passing
xsimd_SOURCE=BUNDLEDto the Arrow C++ CMake configure step so Arrow downloads and uses xsimd 14.0.0 directly, and by passing the vcpkg toolchain file to the Arrow C++ configure step so other vcpkg-managed dependencies are still resolved correctly.