Skip to content

chore(rust): bump edition to 2024, MSRV to 1.85, and update dependencies#4043

Merged
lidavidm merged 3 commits into
apache:mainfrom
if0ne:rust/bump-version
Jun 10, 2026
Merged

chore(rust): bump edition to 2024, MSRV to 1.85, and update dependencies#4043
lidavidm merged 3 commits into
apache:mainfrom
if0ne:rust/bump-version

Conversation

@if0ne

@if0ne if0ne commented Mar 4, 2026

Copy link
Copy Markdown
Contributor

Changes

  • Rust edition 2021 -> 2024 with corresponding source code fixes for new edition requirements
  • MSRV 1.81 -> 1.85 across the Rust workspace
  • Arrow crates 57.x -> 58.x (lower bound tightened from >=53.1.0 to >=58)

@if0ne if0ne requested a review from wjones127 as a code owner March 4, 2026 08:24
@if0ne if0ne marked this pull request as draft March 4, 2026 08:24
Comment thread rust/Cargo.toml Outdated
edition = "2021"
rust-version = "1.81"
edition = "2024"
rust-version = "1.88"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why choose 1.88?
The constraint by arrow seems to be 1.85.
apache/arrow-rs@9d0e8be

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initially, I chose 1.88 because adbc_datafusion has an MSRV of 1.88, and the cargo check produced an error when the 1.85 toolchain was selected.

@if0ne if0ne force-pushed the rust/bump-version branch from af2f86f to 8ea0a46 Compare March 4, 2026 13:24
@eitsupi

eitsupi commented Mar 4, 2026

Copy link
Copy Markdown
Contributor

I suppose some deprecation warnings can be removed.
See #3894

@if0ne if0ne changed the title chore(rust): bump edition to 2024, MSRV to 1.88, and update dependencies chore(rust): bump edition to 2024, MSRV to 1.85, and update dependencies Mar 4, 2026
@if0ne if0ne force-pushed the rust/bump-version branch 2 times, most recently from b928f15 to ffabd02 Compare March 29, 2026 13:55
@if0ne if0ne marked this pull request as ready for review March 29, 2026 13:56
@if0ne

if0ne commented Mar 29, 2026

Copy link
Copy Markdown
Contributor Author

CC @eitsupi @lidavidm

@eitsupi

eitsupi commented Mar 29, 2026

Copy link
Copy Markdown
Contributor

As I've already commented, if we raise the minimum version of arrow, I think we'll need to replace the deprecated function UnionFields::new to UnionFields::try_new.

#[allow(deprecated)] // TODO: remove this once update the minimum arrow version to 57.2.0
UnionFields::new(

@lidavidm lidavidm left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see there's a formatting error

CC @felipecrv any objection to raising MSRV?

@eitsupi eitsupi mentioned this pull request Jun 9, 2026
Signed-off-by: if0ne <pavel.agafonov.al@gmail.com>
@lidavidm lidavidm force-pushed the rust/bump-version branch from 9bea725 to ad2126c Compare June 10, 2026 00:22
@lidavidm

Copy link
Copy Markdown
Member

I squashed/rebased this.

@lidavidm lidavidm merged commit 84493c6 into apache:main Jun 10, 2026
29 of 30 checks passed
@eitsupi

eitsupi commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Note: The reason why 58 was chosen here instead of 57.2 #4014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants