chore(rust): bump edition to 2024, MSRV to 1.85, and update dependencies#4043
Conversation
| edition = "2021" | ||
| rust-version = "1.81" | ||
| edition = "2024" | ||
| rust-version = "1.88" |
There was a problem hiding this comment.
Why choose 1.88?
The constraint by arrow seems to be 1.85.
apache/arrow-rs@9d0e8be
There was a problem hiding this comment.
Initially, I chose 1.88 because adbc_datafusion has an MSRV of 1.88, and the cargo check produced an error when the 1.85 toolchain was selected.
|
I suppose some deprecation warnings can be removed. |
b928f15 to
ffabd02
Compare
|
As I've already commented, if we raise the minimum version of arrow, I think we'll need to replace the deprecated function arrow-adbc/rust/core/src/schemas.rs Lines 36 to 37 in 003f5e6 |
lidavidm
left a comment
There was a problem hiding this comment.
I see there's a formatting error
CC @felipecrv any objection to raising MSRV?
Signed-off-by: if0ne <pavel.agafonov.al@gmail.com>
9bea725 to
ad2126c
Compare
|
I squashed/rebased this. |
|
Note: The reason why 58 was chosen here instead of 57.2 #4014 |
Changes
>=53.1.0to>=58)