[#1984] Refactor use of deprecated StatsImpl.addStatistic to use addStatistics(Set.of(..))#1985
Open
mattrpav wants to merge 1 commit intoapache:mainfrom
Open
[#1984] Refactor use of deprecated StatsImpl.addStatistic to use addStatistics(Set.of(..))#1985mattrpav wants to merge 1 commit intoapache:mainfrom
mattrpav wants to merge 1 commit intoapache:mainfrom
Conversation
…e addStatistics(Set.of(..))
jbonofre
reviewed
May 3, 2026
| addStatistic("dequeues", dequeues); | ||
| addStatistic("inflightMessageSize", inflightMessageSize); | ||
|
|
||
| addStatistics(Set.of(consumedCount, enqueues, dispatched, inflightMessageSize)); |
Member
There was a problem hiding this comment.
I think it should iniclude dequeueshere:
Suggested change
| addStatistics(Set.of(consumedCount, enqueues, dispatched, inflightMessageSize)); | |
| addStatistics(Set.of(consumedCount, enqueues, dispatched, dequeues, inflightMessageSize)); |
| addStatistic("enqueues", enqueues); | ||
| addStatistic("dequeues", dequeues); | ||
| addStatistic("receivedCount", receivedCount); | ||
| addStatistics(Set.of(enqueues, dequeues, receivedCount)); |
Member
There was a problem hiding this comment.
Suggested change
| addStatistics(Set.of(enqueues, dequeues, receivedCount)); | |
| addStatistics(Set.of(enqueues, dequeues, receivedCount)); |
| addStatistic("writeTime", writeTime); | ||
| addStatistic("readTime", readTime); | ||
|
|
||
| addStatistics(Set.of(slowCleanupTime, slowWriteTime, slowReadTime, writeTime, readTime)); |
Member
There was a problem hiding this comment.
Suggested change
| addStatistics(Set.of(slowCleanupTime, slowWriteTime, slowReadTime, writeTime, readTime)); | |
| addStatistics(Set.of(slowCleanupTime, slowWriteTime, slowReadTime, writeTime, readTime)); |
| import org.apache.activemq.management.StatsImpl; | ||
| import org.apache.activemq.management.TimeStatisticImpl; | ||
|
|
||
| import java.util.Set; |
Member
There was a problem hiding this comment.
nit: usually this import should be beofre the org.apache.activemq (same on the other classes).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.