fix: validate effort value before subprocess spawn (#834)#1046
Open
ashishpatel26 wants to merge 2 commits into
Open
fix: validate effort value before subprocess spawn (#834)#1046ashishpatel26 wants to merge 2 commits into
ashishpatel26 wants to merge 2 commits into
Conversation
Invalid effort strings previously caused an opaque ProcessError from the CLI. Now _build_command raises ValueError with a clear message listing valid values before the subprocess is ever spawned. Also ensure ClaudeAgentOptions.effort docstring lists all five valid values including 'xhigh'.
Invalid effort strings previously caused an opaque ProcessError from the CLI. Now _build_command raises ValueError with a clear message listing valid values before the subprocess is ever spawned.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Invalid effort strings (e.g.
effort="ultra") previously reached the CLI and produced an opaqueProcessError. The valid values (low,medium,high,xhigh,max) were undocumented at the Python layer._VALID_EFFORT_VALUESfrozenset constant insubprocess_cli.pyeffortin_build_commandand raiseValueErrorwith the full list of valid values before the subprocess is spawnedNoneTest plan
test_valid_effort_values_acceptedtest_invalid_effort_raises_value_errortest_effort_none_skippedpython -m pytest tests/test_transport.py -vFixes #834