fix(client): infer global model from agent definitions when no model is set#1037
Open
anishesg wants to merge 1 commit into
Open
fix(client): infer global model from agent definitions when no model is set#1037anishesg wants to merge 1 commit into
anishesg wants to merge 1 commit into
Conversation
…is set When agents are defined with explicit model specifications but no global model is configured, the CLI would fall back to its default model, potentially ignoring the user's intent. This fix adds logic in both `ClaudeSDKClient.call_agent` and `InternalClient.call_agent_async` to infer a global model from agent definitions. If all agents use the same model, that model becomes the global default. If agents use different models, the first non-inherit model is selected to ensure at least one user-specified model is respected globally. This prevents the CLI from overriding user-specified agent models with its own defaults. Signed-off-by: anish <anishesg@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When agents are defined with explicit model specifications but no global model is configured, the CLI would fall back to its default model, potentially ignoring the user's intent. This fix adds logic in both
ClaudeSDKClient.call_agentandInternalClient.call_agent_asyncto infer a global model from agent definitions. If all agents use the same model, that model becomes the global default. If agents use different models, the first non-inherit model is selected to ensure at least one user-specified model is respected globally. This prevents the CLI from overriding user-specified agent models with its own defaults.Fixes #994