refactor(protocol): extract server contracts#33708
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@opencode-ai/protocolas the canonical owner of the pure EffectHttpApicontract, endpoint groups, transport errors, and middleware service declarations@opencode-ai/schemawhile preserving Core constructor and schema identity@opencode-ai/server@opencode-ai/serverdeep-import paths through direct compatibility re-exportsArchitecture
The runtime dependency direction is now:
Protocol has no runtime imports from Core. Location middleware retains one type-only Core dev dependency so Effect can carry the exact Location service union through handler construction; replacing that seam belongs to the next Protocol-owned service-algebra/embedded-facade slice rather than weakening middleware types here.
Compatibility
Schema.ClassAPIs moved from Core, includingFileSystem.FindInputBufferusage inSessionsCursorwith Effect Base64URL encoding for browser-safe Protocol consumersVerification
git diff --checkpassed