Skip to content

build: lock file maintenance (main)#33025

Merged
alan-agius4 merged 1 commit intoangular:mainfrom
angular-robot:ng-renovate/main-lock-file-maintenance
Apr 21, 2026
Merged

build: lock file maintenance (main)#33025
alan-agius4 merged 1 commit intoangular:mainfrom
angular-robot:ng-renovate/main-lock-file-maintenance

Conversation

@angular-robot
Copy link
Copy Markdown
Contributor

This PR contains the following updates:

Update Change
lockFileMaintenance All locks refreshed

🔧 This Pull Request updates lock files to use the latest dependency versions.


  • If you want to rebase/retry this PR, check this box

@angular-robot angular-robot added action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project target: automation This PR is targeted to only merge into the branch defined in Github [bot use only] labels Apr 21, 2026
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates a large number of dependencies in pnpm-lock.yaml. Feedback points out that entities@8.0.0 and other packages require Node.js >=20.19.0, which is currently unreleased and will break installations. Additionally, there is a version mismatch between @typescript-eslint/types (8.58.2) and @typescript-eslint/typescript-estree (8.58.1) that should be resolved for consistency.

Comment thread pnpm-lock.yaml
Comment on lines +5029 to +5031
entities@8.0.0:
resolution: {integrity: sha512-zwfzJecQ/Uej6tusMqwAqU/6KL2XaB2VZ2Jg54Je6ahNBGNH6Ek6g3jjNCF0fG9EWQKGZNddNjU5F1ZQn/sBnA==}
engines: {node: '>=20.19.0'}
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The dependency entities@8.0.0 specifies a Node.js engine requirement of >=20.19.0. This version of Node.js has not been released yet (the current latest Node 20 LTS is 20.18.1), which will cause installation failures on all current Node.js 20 environments. Similar restrictive requirements are found in other updated packages like @asamuzakjp/css-color@5.1.11. This update introduces a significant breaking change for the project's runtime compatibility.

Comment thread pnpm-lock.yaml
Comment on lines +3808 to +3810
'@typescript-eslint/types@8.58.2':
resolution: {integrity: sha512-9TukXyATBQf/Jq9AMQXfvurk+G5R2MwfqQGDR2GzGz28HvY/lXNKGhkY+6IOubwcquikWk5cjlgPvD2uAA7htQ==}
engines: {node: ^18.18.0 || ^20.9.0 || >=21.1.0}
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

There is a version mismatch within the @typescript-eslint ecosystem: @typescript-eslint/types is updated to 8.58.2, while @typescript-eslint/typescript-estree remains at 8.58.1. All @typescript-eslint packages should be kept on the same version to avoid type compatibility issues.

See associated pull request for more information.
@angular-robot angular-robot force-pushed the ng-renovate/main-lock-file-maintenance branch from 9f1d25c to 81e6760 Compare April 21, 2026 08:38
@alan-agius4 alan-agius4 merged commit a3cb1a5 into angular:main Apr 21, 2026
35 checks passed
@alan-agius4
Copy link
Copy Markdown
Collaborator

This PR was merged into the repository. The changes were merged into the following branches:

@alan-agius4 alan-agius4 deleted the ng-renovate/main-lock-file-maintenance branch April 21, 2026 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project target: automation This PR is targeted to only merge into the branch defined in Github [bot use only]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants