Double MB fix in validation alert pop up for file size#1918
Merged
Conversation
devgurjar
approved these changes
Jun 24, 2026
Accessibility Violations Found
|
Accessibility Violations Found
|
Accessibility Violations Found
|
1 similar comment
Accessibility Violations Found
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
armaang1729
added a commit
that referenced
this pull request
Jun 25, 2026
* FORMS-23760 : Added Table component support in Core Components (#1879) * added basic config files for the table component * added .content.xml for the table component * added edit toolbar for the table component _cq_editConfig.xml * added table.html * added basic css and js for the table authoring currently refering the dependencies which are declared in the content.xml * added site clientlibs for the table component * added basic config files for the tableheader * added basic config files for the tablerow * added site clientlibs for tableheader * added clientlibs folder in the tablerow * added the table component in examples folder along with cq_template * added runtime dependencies in the runtime all for the table component * replaced the tr elements from the div elements to fix the selecting issue * added action configs in the edit toolbar for the table component * added action configs for the table row and the tableroweditorhook.js for handling this * removed the add row option from the tableHeaderRow * updated the header cells from the textinput to text type in the templates * added the addCol and deleteCol actions and also there handlers * removed cell numbers from dynamic addition of the table cols and rows * added the feature of repeatable panels to the table row at runtime * added the replace feature for the tablecell to any component which is present * removed the delete options from the table cells in the table row * in this commit table tags have gone -> repeatable panels not working correctly here * added files to fix the repeatative panels with the table tags * fixed the repeatable rows with indexing * changed the authoring from divs to tabletags sacirificing the touch ui for now * fixed the touch ui with the table tags * fixed the tablecell css having controls * removed the tableeditor.css file * added replace feature to the components of the table Header also * fixed the refresh issue by adding authoring dialogs for table row and table header * added cypress tests and collaterals for testing * added sling folder for collaterals * fixed the test cases * fixed the content.xml * fixed the failing testcases * updated the year to 2026 * fixed the short and long description for the table component * removed unsupported authoring from the table component * refactored the table.html * updated README for the table Component * Resolved Conflicts * added sorting feature for the table component * enabled sorting button during authoring too * added feature to disable/enable sorting on a particular column of the table * added authoring options for sorting and column width * added dor support for table component * added dor testing * added the feature of merge and split cell during runtime by adding colspan in publish html * updated README for table, tableheader, tablerow * added the feature for merge row cells and commented out the header cells merge feature * added testing for second phase features * fixed review comments 1 * fixed review comments 2 * fixed cypress tests * fixed coverage * fixed the sorting behaviour to improve the archaic behavior * fixed cypress testing mergesplit feature * fixed cypress testing * moved .css changes from core component to theme canvas --------- Co-authored-by: Armaan Gupta <armaang@Armaans-MacBook-Pro.local> * FORMS-24585 AEP submission changes (#1911) * Fix code formatting for FormContainerImpl.java (#1914) * FORMS-24585 Adding sandboxname in config (#1917) Co-authored-by: shraddhasingh683 <shraddhasingh683@gmail.com> * Double MB fix in validation alert pop up for file size (#1918) * file input upload error fix * double MB java change reverted --------- Co-authored-by: Rajat Khurana <rajatkhurana@adobe.com> * feat: FORMS-25252 add server-side validation (SSV) (#1902) * feat(af-core): FORMS-25252 add server-side validation (SSV) for form container * fix(ssv): gate SSV dialog behind FT_FORMS-25252 feature toggle * copy writing fixed for ssv config --------- Co-authored-by: Rajat Khurana <rajatkhurana@adobe.com> --------- Co-authored-by: Armaan Gupta <armaang@Armaans-MacBook-Pro.local> Co-authored-by: shraddhasingh683 <shraddhasingh683@gmail.com> Co-authored-by: anshikag-adobe <anshikag@adobe.com> Co-authored-by: Rajat Khurana <30727855+rajatofficial@users.noreply.github.com> Co-authored-by: Rajat Khurana <rajatkhurana@adobe.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: