feat: FORMS-25252 add server-side validation (SSV)#1902
Conversation
Accessibility Violations Found
|
10d09e8 to
3d10aa4
Compare
Accessibility Violations Found
|
Accessibility Violations Found
|
2 similar comments
Accessibility Violations Found
|
Accessibility Violations Found
|
| submitProps.computeIfAbsent(SS_SPREADSHEET, k -> new LinkedHashMap<String, Object>()); | ||
| ((Map<String, Object>) submitProps.get(SS_SPREADSHEET)).put(entry.getKey(), entry.getValue()); | ||
| } | ||
| // SSV properties (enableServerSideValidation, ssvCloudServicePath) are intentionally |
There was a problem hiding this comment.
nitpick: comment not required here
| granite:class="cmp-adaptiveform-container__enablessv" | ||
| name="./enableServerSideValidation" | ||
| text="Enable Server-Side Validation" | ||
| value="true" |
There was a problem hiding this comment.
I think default value should be false
There was a problem hiding this comment.
Yes made it false.
Accessibility Violations Found
|
1 similar comment
Accessibility Violations Found
|
| public static final String PN_SUBMIT_EMAIL_CC = "cc"; | ||
| public static final String PN_SUBMIT_EMAIL_BCC = "bcc"; | ||
| public static final String PN_SUBMIT_SPREADSHEETURL = "spreadsheetUrl"; | ||
| public static final String PN_ENABLE_SERVER_SIDE_VALIDATION = "enableServerSideValidation"; |
There was a problem hiding this comment.
all OOTB properties should be prefixed with fd:
There was a problem hiding this comment.
These properties should not be part of the model.json output since they are server side, there can be a use-case for EDS submit, that can be handled later
There was a problem hiding this comment.
These are not part of model.json; these are just for internal code use.
| </cui> | ||
| </uiSettings> | ||
| </thankYouMessage> | ||
| <enableServerSideValidation |
There was a problem hiding this comment.
This should be hidden and only enabled if someone selects enable server side validation
There was a problem hiding this comment.
Discussed with Anurag and Sudhanshu that, in order to improve the archaic behaviour, we should keep only one dropdown with a default value of None.
| jcr:primaryType="nt:unstructured" | ||
| sling:resourceType="granite/ui/components/coral/foundation/form/checkbox" | ||
| fieldLabel="Server-Side Validation" | ||
| fieldDescription="Call an Adobe I/O validator endpoint before the submit action runs." |
There was a problem hiding this comment.
We need to have help article for users to understand how to create one
There was a problem hiding this comment.
Yes I will be creating a Doc for the customer.
| let defaultSubmissionError = FormView.LanguageUtils.getTranslatedString(self.getLang(), "InternalFormSubmissionError"); | ||
| const globals = { | ||
| form: self.getModel().getRuleNode(), | ||
| formModel: self.getModel(), |
There was a problem hiding this comment.
Its not required. Removed it.
| <enableServerSideValidation | ||
| jcr:primaryType="nt:unstructured" | ||
| sling:resourceType="granite/ui/components/coral/foundation/form/checkbox" | ||
| fieldLabel="Server-Side Validation" |
There was a problem hiding this comment.
Can we create a github clone so that users can refer that as sample to deploy Adobe IO action ? I want to make sure that they dont spend a lot of time doing this
There was a problem hiding this comment.
Yes, I will be creating one.
7b1c652 to
665f05d
Compare
Accessibility Violations Found
|
1 similar comment
Accessibility Violations Found
|
Accessibility Violations Found
|
1 similar comment
Accessibility Violations Found
|
Accessibility Violations Found
|
1 similar comment
Accessibility Violations Found
|
b0589ab to
e397c06
Compare
Accessibility Violations Found
|
3 similar comments
Accessibility Violations Found
|
Accessibility Violations Found
|
Accessibility Violations Found
|
Accessibility Violations Found
|
Accessibility Violations Found
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Accessibility Violations Found
|
1 similar comment
Accessibility Violations Found
|
Accessibility Violations Found
|
Accessibility Violations Found
|
0068aba to
a69124c
Compare
Accessibility Violations Found
|
1 similar comment
Accessibility Violations Found
|
| } | ||
|
|
||
| private List<Resource> getCloudConfigsByGroup(SlingHttpServletRequest request, ResourceResolver resourceResolver) { | ||
| List<Resource> resources = new ArrayList<>(); |
There was a problem hiding this comment.
This is incorrect, we have helpers in cq-guides (addon) for such use-cases, you should re-use that
rismehta
left a comment
There was a problem hiding this comment.
Approving. but there are few unresolved comments, address them later
Accessibility Violations Found
|
Accessibility Violations Found
|
60d88c2 to
45900ec
Compare
45900ec to
b86b3ea
Compare
Accessibility Violations Found
|
3 similar comments
Accessibility Violations Found
|
Accessibility Violations Found
|
Accessibility Violations Found
|
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: