FORMS-24585 AEP submission changes#1870
Open
shraddhasingh683 wants to merge 1 commit into
Open
Conversation
syamavarm
reviewed
Jun 24, 2026
| if (request == null || ComponentUtils.shouldIncludeSubmitProperties(request)) { | ||
| String actionName = resource.getValueMap().get(ReservedProperties.PN_SUBMIT_ACTION_NAME, String.class); | ||
| if (request == null || ComponentUtils.shouldIncludeSubmitProperties(request) | ||
| || (StringUtils.isNotBlank(actionName) && (SS_AEP.equals(actionName)))) { |
Member
There was a problem hiding this comment.
why is this action name check required here? It should have been generic
syamavarm
reviewed
Jun 24, 2026
| public static final String PN_SUBMIT_SPREADSHEETURL = "spreadsheetUrl"; | ||
| // AEP submit action properties | ||
| public static final String SS_AEP = "aep"; | ||
| public static final String PN_SUBMIT_AEP_SCHEMA_REF_ID = "schemaRefId"; |
Member
There was a problem hiding this comment.
I hope this doesnt conflict with a schemaRef that AF already uses.
syamavarm
reviewed
Jun 24, 2026
| // AEP submit action properties | ||
| public static final String SS_AEP = "aep"; | ||
| public static final String PN_SUBMIT_AEP_SCHEMA_REF_ID = "schemaRefId"; | ||
| public static final String PN_SUBMIT_AEP_IMS_ORG_ID = "imsOrgId"; |
Member
There was a problem hiding this comment.
do we need any prefix so that it doesn't conflict with other properties?
Member
|
There are no unit tests in this PR. I think we should be adding tests. I see tests for spreadsheet already, if we can model along the same lines. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: