Skip to content

Add dotnet-version: latest support with dotnet-channel input#730

Open
mahabaleshwars wants to merge 3 commits intoactions:mainfrom
mahabaleshwars:feature/497-dotnet-version-latest-with-channel
Open

Add dotnet-version: latest support with dotnet-channel input#730
mahabaleshwars wants to merge 3 commits intoactions:mainfrom
mahabaleshwars:feature/497-dotnet-version-latest-with-channel

Conversation

@mahabaleshwars
Copy link
Copy Markdown

Description:
Adds dotnet-version: latest support to automatically install the highest active .NET SDK via the releases index API. Introduces an optional dotnet-channel input (LTS, STS, A.B, A.B.Cxx) to filter the resolved version—ignored with a warning if dotnet-version isn't latest. Removes signed and validated from dotnet-quality, retaining only daily, preview, and ga.

Related issue:
#497
#640

Check list:

  • Mark if documentation changes are required.
  • Mark if tests were added or updated to cover the changes.

@mahabaleshwars mahabaleshwars requested a review from a team as a code owner April 15, 2026 14:25
Copilot AI review requested due to automatic review settings April 15, 2026 14:25
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds support for dotnet-version: latest in the action by resolving the highest active .NET SDK channel via the .NET releases index API, with an optional dotnet-channel input to constrain the resolution. Updates the supported dotnet-quality values and refreshes docs/tests/e2e coverage accordingly.

Changes:

  • Implement latest resolution (with optional dotnet-channel) and wire it through installer/version resolution.
  • Remove signed and validated from supported dotnet-quality values (now daily, preview, ga).
  • Update action metadata, documentation, unit tests, and e2e workflows for the new behavior.

Reviewed changes

Copilot reviewed 8 out of 9 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/setup-dotnet.ts Validates/handles dotnet-channel, normalizes latest, passes channel through to installer.
src/installer.ts Adds latest resolution via releases index API and threads quality/dotnetChannel into resolver.
dist/setup/index.js Compiled bundle reflecting the new resolver/channel logic.
action.yml Documents latest, adds dotnet-channel input, updates dotnet-quality description.
tests/setup-dotnet.test.ts Updates dotnet-quality expectations; adds dotnet-channel validation/warning tests.
tests/latest-version.test.ts New unit tests for latest resolution and channel/quality filtering behavior.
tests/installer.test.ts Adjusts tests to no longer depend on the removed QualityOptions import/casts.
README.md Documents latest, dotnet-channel, and updated dotnet-quality behavior.
.github/workflows/e2e-tests.yml Adds e2e coverage for latest; adjusts proxy test container and installs PowerShell.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/e2e-tests.yml Outdated
@Frulfump
Copy link
Copy Markdown

Maybe worth checking dotnet/install-scripts#418 to either give feedback or otherwise just be aware of it.

{
'channel-version': '9.0',
'support-phase': 'active',
'release-type': 'lts'
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't a true for the real 9.0 release, maybe intentional for the test? Otherwise it makes more sense to match what the real releases are?

@Frulfump
Copy link
Copy Markdown

Added an issue that tracks the failing pipeline due to npm audit failing
#731

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants