Skip to content

[Accton] Check TX_DISABLE support before access in onlp_sfpi_control_… #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
eric271110 wants to merge 3 commits into
base: support_linux_6.1
Choose a base branch
from
Open

[Accton] Check TX_DISABLE support before access in onlp_sfpi_control_… #194

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0097881
[Accton] Check TX_DISABLE support before access in onlp_sfpi_control_…
eric271110 Jun 12, 2026
77205c3
[Accton] remove redundant CMIS bank setting in control_get/set
eric271110 Jun 15, 2026
08284d2
[Accton]Add SFP functionality (LP mode, reset, TX disable)
eric271110 Jun 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
56 changes: 45 additions & 11 deletions ...atforms/accton/x86-64/as7535-28xb/onlp/builds/x86_64_accton_as7535_28xb/module/src/sfpi.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,8 @@
#define QSFP_DD_PAGE_ADMIN_INFO 0x0
#define QSFP_DD_PAGE_ADVERTISING 0x1
#define QSFP_DD_PAGE_LANE_CTRL 0x10
#define QSFP_DD_LOWER_OFFSET_STATUS 0x02
#define QSFP_DD_FLAT_MEM 0x80 /* byte 0x02 bit 7 */
#define QSFP_DD_P01H_OFFSET_CONTROL_1 0x9B
#define QSFP_DD_P01H_TX_DISABLE_SUPPORT 0x2
#define QSFP_DD_P10H_OFFSET_OUTPUT_DISABLE_TX 0x82
Expand Down Expand Up @@ -318,6 +320,7 @@ onlp_sfpi_control_set(int port, onlp_sfp_control_t control, int value)
{
int present = 0;
int identifier = 0;
int status_byte = 0;
int support_ctrls = 0;
int mbit_identifier;
int mbit_value;
Expand All @@ -337,6 +340,15 @@ onlp_sfpi_control_set(int port, onlp_sfp_control_t control, int value)
}

if (identifier == QSFP_DD_IDENTIFIER) {
/* Flat-memory CMIS modules do not implement page 01h/10h */
if ((status_byte = onlp_sfpi_dev_readb(port, XCVR_PORT_EEPROM_DEVADDR, QSFP_DD_LOWER_OFFSET_STATUS)) < 0) {
AIM_LOG_ERROR("Failed to read Status byte, unable to write tx_disable status to port(%d)\r\n", port);
return ONLP_STATUS_E_INTERNAL;
}
if (status_byte & QSFP_DD_FLAT_MEM) {
AIM_LOG_ERROR("Setting tx_disable to port(%d) is not supported (flat-memory module)\r\n", port);
return ONLP_STATUS_E_UNSUPPORTED;
}
if ((rv = onlp_sfpi_dev_writeb(port, XCVR_PORT_EEPROM_DEVADDR, QSFP_EEPROM_OFFSET_BANK_SELECT, 0)) < 0) {
AIM_LOG_ERROR("Failed to set Bank 0, unable to write tx_disable status to port(%d)\r\n", port);
return ONLP_STATUS_E_INTERNAL;
Expand All @@ -351,10 +363,6 @@ onlp_sfpi_control_set(int port, onlp_sfp_control_t control, int value)
goto restore;
}
if (support_ctrls & QSFP_DD_P01H_TX_DISABLE_SUPPORT) {
if ((rv = onlp_sfpi_dev_writeb(port, XCVR_PORT_EEPROM_DEVADDR, QSFP_EEPROM_OFFSET_BANK_SELECT, 0)) < 0) {
AIM_LOG_ERROR("Failed to set Bank 0 on port(%d)\r\n", port);
goto restore;
}
if ((rv = onlp_sfpi_dev_writeb(port, XCVR_PORT_EEPROM_DEVADDR, QSFP_EEPROM_OFFSET_PAGE_SELECT, QSFP_DD_PAGE_LANE_CTRL)) < 0 ) {
AIM_LOG_ERROR("Failed to switch to Lane Control Page (Page 0x%02x) on port(%d)\r\n",
QSFP_DD_PAGE_LANE_CTRL, port);
Expand Down Expand Up @@ -469,6 +477,8 @@ onlp_sfpi_control_get(int port, onlp_sfp_control_t control, int* value)
{
int present = 0;
int identifier = 0;
int status_byte = 0;
int support_ctrls = 0;
int tx_dis = 0;
int multirate = 0;
int mbit_identifier;
Expand Down Expand Up @@ -510,18 +520,42 @@ onlp_sfpi_control_get(int port, onlp_sfp_control_t control, int* value)
}

if (identifier == QSFP_DD_IDENTIFIER) {
/* Flat-memory CMIS modules do not implement page 01h/10h */
if ((status_byte = onlp_sfpi_dev_readb(port, XCVR_PORT_EEPROM_DEVADDR, QSFP_DD_LOWER_OFFSET_STATUS)) < 0) {
AIM_LOG_ERROR("Failed to read Status byte, unable to read tx_disable status from port(%d)\r\n", port);
return ONLP_STATUS_E_INTERNAL;
}
if (status_byte & QSFP_DD_FLAT_MEM) {
AIM_LOG_ERROR("Getting tx_disable from port(%d) is not supported (flat-memory module)\r\n", port);
return ONLP_STATUS_E_UNSUPPORTED;
}
if ((rv = onlp_sfpi_dev_writeb(port, XCVR_PORT_EEPROM_DEVADDR, QSFP_EEPROM_OFFSET_BANK_SELECT, 0)) < 0) {
AIM_LOG_ERROR("Failed to set Bank 0, unable to read tx_disable status from port(%d)\r\n", port);
return ONLP_STATUS_E_INTERNAL;
}
if ((rv = onlp_sfpi_dev_writeb(port, XCVR_PORT_EEPROM_DEVADDR, QSFP_EEPROM_OFFSET_PAGE_SELECT, QSFP_DD_PAGE_LANE_CTRL)) < 0) {
AIM_LOG_ERROR("Failed to switch to Lane Control Page (Page 0x%02x) on port(%d)\r\n",
QSFP_DD_PAGE_LANE_CTRL, port);
if ((rv = onlp_sfpi_dev_writeb(port, XCVR_PORT_EEPROM_DEVADDR, QSFP_EEPROM_OFFSET_PAGE_SELECT, QSFP_DD_PAGE_ADVERTISING)) < 0) {
AIM_LOG_ERROR("Failed to switch to Advertising Page on port(%d)\r\n", port);
goto restore;
}
if ((tx_dis = onlp_sfpi_dev_readb(port, XCVR_PORT_EEPROM_DEVADDR, QSFP_DD_P10H_OFFSET_OUTPUT_DISABLE_TX)) < 0) {
AIM_LOG_ERROR("Failed to read TX_DISABLE value from Lane Control register on port(%d)\r\n", port);
rv = tx_dis;
if ((support_ctrls = onlp_sfpi_dev_readb(port, XCVR_PORT_EEPROM_DEVADDR, QSFP_DD_P01H_OFFSET_CONTROL_1)) < 0) {
AIM_LOG_ERROR("Failed to read Support Control on port(%d)\r\n", port);
rv = support_ctrls;
goto restore;
}
if (support_ctrls & QSFP_DD_P01H_TX_DISABLE_SUPPORT) {
if ((rv = onlp_sfpi_dev_writeb(port, XCVR_PORT_EEPROM_DEVADDR, QSFP_EEPROM_OFFSET_PAGE_SELECT, QSFP_DD_PAGE_LANE_CTRL)) < 0) {
AIM_LOG_ERROR("Failed to switch to Lane Control Page (Page 0x%02x) on port(%d)\r\n",
QSFP_DD_PAGE_LANE_CTRL, port);
goto restore;
}
if ((tx_dis = onlp_sfpi_dev_readb(port, XCVR_PORT_EEPROM_DEVADDR, QSFP_DD_P10H_OFFSET_OUTPUT_DISABLE_TX)) < 0) {
AIM_LOG_ERROR("Failed to read TX_DISABLE value from Lane Control register on port(%d)\r\n", port);
rv = tx_dis;
goto restore;
}
} else {
AIM_LOG_ERROR("Getting tx_disable from port(%d) is not supported\r\n", port);
rv = ONLP_STATUS_E_UNSUPPORTED;
goto restore;
}

Expand All @@ -533,7 +567,7 @@ onlp_sfpi_control_get(int port, onlp_sfp_control_t control, int* value)

if (rv < 0) {
AIM_LOG_ERROR("Unable to get tx_disable status from port(%d)\r\n", port);
return ONLP_STATUS_E_INTERNAL;
return (rv == ONLP_STATUS_E_UNSUPPORTED) ? rv : ONLP_STATUS_E_INTERNAL;
}
*value = (tx_dis & 0xff);
return ONLP_STATUS_OK;
Expand Down
59 changes: 47 additions & 12 deletions ...forms/accton/x86-64/as7926-40xfb/onlp/builds/x86_64_accton_as7926_40xfb/module/src/sfpi.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,8 @@ static const int port_bus_index[NUM_OF_SFP_PORT] = {
#define QSFP_DD_PAGE_ADMIN_INFO 0x0
#define QSFP_DD_PAGE_ADVERTISING 0x1
#define QSFP_DD_PAGE_LANE_CTRL 0x10
#define QSFP_DD_LOWER_OFFSET_STATUS 0x02
#define QSFP_DD_FLAT_MEM 0x80 /* byte 0x02 bit 7 */
#define QSFP_DD_P01H_TX_DISABLE_SUPPORT 0x2
#define QSFP_DD_LPMODE 0x10

Expand Down Expand Up @@ -260,6 +262,7 @@ onlp_sfpi_control_set(int port, onlp_sfp_control_t control, int value)
int present = 0;
int lpmode_value = 0;
int identifier = 0;
int status_byte = 0;
int eeprom_control;

VALIDATE_PORT(port);
Expand Down Expand Up @@ -287,7 +290,21 @@ onlp_sfpi_control_set(int port, onlp_sfp_control_t control, int value)
rv = ONLP_STATUS_E_INTERNAL;
}
else if (identifier == QSFP_DD_IDENTIFIER) { /*QSFP DD*/
if(onlp_sfpi_dev_writeb(port, PORT_EEPROM_DEVADDR, QSFP_DD_EEPROM_OFFSET_PAGE_SELECT, QSFP_DD_PAGE_ADVERTISING) <0 ){
/* Flat-memory CMIS modules do not implement page 01h/10h */
if ((status_byte = onlp_sfpi_dev_readb(port, PORT_EEPROM_DEVADDR, QSFP_DD_LOWER_OFFSET_STATUS)) < 0) {
AIM_LOG_ERROR("Failed to read Status byte, unable to write tx_disable status to port(%d)\r\n", port);
rv = ONLP_STATUS_E_INTERNAL;
}
else if (status_byte & QSFP_DD_FLAT_MEM) {
AIM_LOG_ERROR("Setting tx_disable to port(%d) is not supported (flat-memory module)\r\n", port);
rv = ONLP_STATUS_E_UNSUPPORTED;
}
else if(onlp_sfpi_dev_writeb(port, PORT_EEPROM_DEVADDR, QSFP_DD_EEPROM_OFFSET_BANK_SELECT, 0) < 0){
AIM_LOG_ERROR("Unable to write tx_disable status to port(%d): write bank to eeprom fail\r\n",
port);
rv = ONLP_STATUS_E_INTERNAL;
}
else if(onlp_sfpi_dev_writeb(port, PORT_EEPROM_DEVADDR, QSFP_DD_EEPROM_OFFSET_PAGE_SELECT, QSFP_DD_PAGE_ADVERTISING) <0 ){
AIM_LOG_ERROR("Unable to write tx_disable status to port(%d): write page to eeprom fail\r\n",
port);
rv = ONLP_STATUS_E_INTERNAL;
Expand All @@ -300,12 +317,7 @@ onlp_sfpi_control_set(int port, onlp_sfp_control_t control, int value)
rv = ONLP_STATUS_E_INTERNAL;
}
else if (eeprom_control & QSFP_DD_P01H_TX_DISABLE_SUPPORT){
if (onlp_sfpi_dev_writeb(port, PORT_EEPROM_DEVADDR, QSFP_DD_EEPROM_OFFSET_BANK_SELECT, 0) < 0) {
AIM_LOG_ERROR("Unable to write tx_disable status to port(%d): write bank to eeprom fail\r\n",
port);
rv = ONLP_STATUS_E_INTERNAL;
}
else if (onlp_sfpi_dev_writeb(port, PORT_EEPROM_DEVADDR, QSFP_DD_EEPROM_OFFSET_PAGE_SELECT, QSFP_DD_PAGE_LANE_CTRL) < 0) {
if (onlp_sfpi_dev_writeb(port, PORT_EEPROM_DEVADDR, QSFP_DD_EEPROM_OFFSET_PAGE_SELECT, QSFP_DD_PAGE_LANE_CTRL) < 0) {
AIM_LOG_ERROR("Unable to write tx_disable status to port(%d): write page to eeprom fail\r\n",
port);
rv = ONLP_STATUS_E_INTERNAL;
Expand Down Expand Up @@ -458,6 +470,8 @@ onlp_sfpi_control_get(int port, onlp_sfp_control_t control, int* value)
int present = 0;
int lpmode_value = 0;
int identifier = 0;
int status_byte = 0;
int support_ctrls = 0;
int tx_dis = 0;

VALIDATE_PORT(port);
Expand Down Expand Up @@ -503,14 +517,35 @@ onlp_sfpi_control_get(int port, onlp_sfp_control_t control, int* value)
rv = ONLP_STATUS_E_INTERNAL;
}
else if (identifier == QSFP_DD_IDENTIFIER) {/* QSFP DD */
if(onlp_sfpi_dev_writeb(port, PORT_EEPROM_DEVADDR, QSFP_DD_EEPROM_OFFSET_BANK_SELECT, 0) < 0){
/* Flat-memory CMIS modules do not implement page 01h/10h */
if ((status_byte = onlp_sfpi_dev_readb(port, PORT_EEPROM_DEVADDR, QSFP_DD_LOWER_OFFSET_STATUS)) < 0) {
AIM_LOG_ERROR("Failed to read Status byte, unable to read tx_disable status from port(%d)\r\n", port);
rv = ONLP_STATUS_E_INTERNAL;
}
else if (status_byte & QSFP_DD_FLAT_MEM) {
AIM_LOG_ERROR("Getting tx_disable from port(%d) is not supported (flat-memory module)\r\n", port);
rv = ONLP_STATUS_E_UNSUPPORTED;
}
else if(onlp_sfpi_dev_writeb(port, PORT_EEPROM_DEVADDR, QSFP_DD_EEPROM_OFFSET_BANK_SELECT, 0) < 0){
AIM_LOG_ERROR("Unable to read tx_disable status from port(%d): write bank to eeprom fail\r\n",
port);
rv = ONLP_STATUS_E_INTERNAL;
}
else if(onlp_sfpi_dev_writeb(port, PORT_EEPROM_DEVADDR, QSFP_DD_EEPROM_OFFSET_PAGE_SELECT, QSFP_DD_PAGE_LANE_CTRL) < 0 ){
AIM_LOG_ERROR("Unable to read tx_disable status from port(%d): write page to eeprom fail\r\n",
port);
else if(onlp_sfpi_dev_writeb(port, PORT_EEPROM_DEVADDR, QSFP_DD_EEPROM_OFFSET_PAGE_SELECT, QSFP_DD_PAGE_ADVERTISING) < 0){
AIM_LOG_ERROR("Failed to switch to Advertising Page on port(%d)\r\n", port);
rv = ONLP_STATUS_E_INTERNAL;
}
else if((support_ctrls = onlp_sfpi_dev_readb(port, PORT_EEPROM_DEVADDR, QSFP_DD_EEPROM_P01H_OFFSET_CONTROL_1)) < 0){
AIM_LOG_ERROR("Failed to read Support Control on port(%d)\r\n", port);
rv = ONLP_STATUS_E_INTERNAL;
}
else if (!(support_ctrls & QSFP_DD_P01H_TX_DISABLE_SUPPORT)) {
AIM_LOG_ERROR("Getting tx_disable from port(%d) is not supported\r\n", port);
rv = ONLP_STATUS_E_UNSUPPORTED;
}
else if(onlp_sfpi_dev_writeb(port, PORT_EEPROM_DEVADDR, QSFP_DD_EEPROM_OFFSET_PAGE_SELECT, QSFP_DD_PAGE_LANE_CTRL) < 0){
AIM_LOG_ERROR("Failed to switch to Lane Control Page (Page 0x%02x) on port(%d)\r\n",
QSFP_DD_PAGE_LANE_CTRL, port);
rv = ONLP_STATUS_E_INTERNAL;
}
else {
Expand All @@ -521,7 +556,7 @@ onlp_sfpi_control_get(int port, onlp_sfp_control_t control, int* value)
rv = ONLP_STATUS_E_INTERNAL;
}
else{
*value = tx_dis;
*value = (tx_dis & 0xff);
rv = ONLP_STATUS_OK;
}
}
Expand Down
Loading