Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/source/conf.py
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@
"https://ftp.suse.com/pub/projects/security/yaml/suse-cvss-scores.yaml",
"http://ftp.suse.com/pub/projects/security/yaml/",
r"https://nixos\.wiki/", # NixOS wiki blocks CI bots with 403
"https://usn.ubuntu.com/usn-db/database-all.json.bz2",
]

# Add any Sphinx extension module names here, as strings. They can be
Expand Down
2 changes: 1 addition & 1 deletion requirements-dev.txt
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ typecode==30.2.0
typecode-libmagic==5.39.210531
typing_extensions==4.13.0
tzlocal==5.3.1
univers==30.12.0
univers==32.0.1
uritemplate==4.2.0
urllib3==2.6.3
uvicorn==0.42.0
Expand Down
2 changes: 1 addition & 1 deletion requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ typecode==30.2.0
typecode-libmagic==5.39.210531
typing_extensions==4.13.0
tzlocal==5.3.1
univers==30.12.0
univers==32.0.1
uritemplate==4.2.0
urllib3==2.6.3
webencodings==0.5.1
2 changes: 1 addition & 1 deletion setup.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ install_requires =

#essentials
packageurl-python==0.17.6
univers==30.12.0
univers==32.0.1
license-expression==30.3.1

# file and data formats
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
# Generated by Django 5.2.11 on 2026-05-01 10:38

from django.db import migrations


class Migration(migrations.Migration):

dependencies = [
("vulnerabilities", "0124_advisoryv2_remove_malformed_aliases_and_dvisory_id"),
]

def clean_empty_vers_range(apps, _):
ImpactedPackage = apps.get_model("vulnerabilities", "ImpactedPackage")

ImpactedPackage.objects.filter(affecting_vers__regex=r"vers:[^/]+/$").update(
affecting_vers=None
)
ImpactedPackage.objects.filter(fixed_vers__regex=r"vers:[^/]+/$").update(fixed_vers=None)

ImpactedPackage.objects.filter(
affecting_vers__isnull=True,
fixed_vers__isnull=True,
introduced_by_package_commit_patches__isnull=True,
fixed_by_package_commit_patches__isnull=True,
).distinct().delete()

operations = [
migrations.RunPython(clean_empty_vers_range, reverse_code=migrations.RunPython.noop),
]
87 changes: 87 additions & 0 deletions vulnerabilities/tests/test_data_migrations.py
Original file line number Diff line number Diff line change
Expand Up @@ -1184,3 +1184,90 @@ def test_migration_processes_malformed_aliases(self):
else:
assert adv_exists == False
assert alias_exists == False


class TestCleanVersRangeMigration(TestMigrations):
app_name = "vulnerabilities"
migrate_from = "0124_advisoryv2_remove_malformed_aliases_and_dvisory_id"
migrate_to = "0125_clean_vers_range_without_constraints"

def setUpBeforeMigration(self, apps):
AdvisoryV2 = apps.get_model("vulnerabilities", "AdvisoryV2")
ImpactedPackage = apps.get_model("vulnerabilities", "ImpactedPackage")
PackageCommitPatch = apps.get_model("vulnerabilities", "PackageCommitPatch")

self.advisory1 = AdvisoryV2.objects.create(
unique_content_id="content_id_old",
url="https://old.example.com",
summary="Old advisory",
advisory_id="test_adv1",
avid="test_pipeline/test_adv",
datasource_id="test_pipeline",
)

self.advisory2 = AdvisoryV2.objects.create(
unique_content_id="content_id_old2",
url="https://old.example.com",
summary="Old 2 advisory",
advisory_id="test_adv2",
avid="test_pipeline/test_adv",
datasource_id="test_pipeline",
)

ImpactedPackage.objects.create(
advisory=self.advisory1,
base_purl="pkg:npm/foobar0",
affecting_vers="vers:npm/",
fixed_vers="vers:npm/",
)

self.impact1 = ImpactedPackage.objects.create(
advisory=self.advisory1,
base_purl="pkg:npm/foobar1",
affecting_vers="vers:npm/>=5.3.1|<6.0.0",
fixed_vers="vers:npm/",
)

self.impact2 = ImpactedPackage.objects.create(
advisory=self.advisory1,
base_purl="pkg:npm/foobar2",
affecting_vers="vers:npm/",
fixed_vers="vers:npm/",
)

self.pkg_commit_patch1 = PackageCommitPatch.objects.create(
commit_hash="8c001a11dbcb3eb6d851e18f4cefa080af5fb398",
vcs_url="https://github.com/aboutcode-org/test1/",
patch_text="test1",
)

self.impact3 = ImpactedPackage.objects.create(
advisory=self.advisory2,
base_purl="pkg:npm/foobar3",
affecting_vers="vers:npm/>5.6.7",
fixed_vers="vers:npm/5.6.8",
)

self.impact2.fixed_by_package_commit_patches.add(self.pkg_commit_patch1)

self.assertEqual(ImpactedPackage.objects.count(), 4)

def test_empty_impactepackages_removed(self):
ImpactedPackage = apps.get_model("vulnerabilities", "ImpactedPackage")

self.assertEqual(ImpactedPackage.objects.count(), 3)

def test_empty_fixed_vers_cleaned(self):
self.impact1.refresh_from_db()
self.assertEqual(self.impact1.fixed_vers, None)

def test_empty_affecting_vers_cleaned(self):
self.impact2.refresh_from_db()
self.assertEqual(self.impact2.affecting_vers, None)
self.assertEqual(self.impact2.fixed_vers, None)

def test_no_change_to_valid_vers(self):
self.impact3.refresh_from_db()
self.assertEqual(self.impact3.affecting_vers, "vers:npm/>5.6.7")
self.assertEqual(self.impact3.fixed_vers, "vers:npm/5.6.8")
self.assertEqual(self.impact3.advisory.advisory_id, "test_adv2")
Loading