Skip to content

fix(tck): resolve capability test failures for extensions and push notifications #804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sherryfox wants to merge 1 commit into
base: 0.3.x-compat
Choose a base branch
from
+11 −2
Open

fix(tck): resolve capability test failures for extensions and push notifications #804

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions server-common/src/main/java/io/a2a/server/requesthandlers/DefaultRequestHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -326,8 +326,13 @@ public EventKind onMessageSend(MessageSendParams params, ServerCallContext conte
}
}
}
if (kind instanceof Task taskResult && !taskId.equals(taskResult.getId())) {
throw new InternalError("Task ID mismatch in agent response");
if (kind instanceof Task taskResult) {
if (shouldAddPushInfo(params)) {
pushConfigStore.setInfo(taskResult.getId(), params.configuration().pushNotificationConfig());
}
if (taskId != null && !taskId.equals(taskResult.getId())) {
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot Apr 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

While adding the taskId != null check prevents a NullPointerException during the comparison, taskId being null (which occurs for new tasks) still poses a significant risk. Specifically, taskId is used as a key for runningAgents (a ConcurrentHashMap) at lines 242, 256, and 342. Since ConcurrentHashMap does not allow null keys, these operations will throw a NullPointerException before this line is even reached. Consider ensuring a non-null task ID is available (e.g., by generating a temporary one) before interacting with runningAgents.

throw new InternalError("Task ID mismatch in agent response");
}
}

// Send push notification after initial return (for both blocking and non-blocking)
Expand Down
4 changes: 4 additions & 0 deletions spec/src/main/java/io/a2a/spec/AgentCapabilities.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,10 @@
public record AgentCapabilities(boolean streaming, boolean pushNotifications, boolean stateTransitionHistory,
List<AgentExtension> extensions) {

public AgentCapabilities {
extensions = extensions == null ? List.of() : extensions;
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot Apr 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Using List.copyOf is preferred here to ensure the extensions list is unmodifiable and to provide a defensive copy if a mutable list was passed to the constructor. This maintains the immutability of the record and aligns with the pattern used in other classes like Task.

Suggested change
extensions = extensions == null ? List.of() : extensions;
extensions = extensions == null ? List.of() : List.copyOf(extensions);

}

public static class Builder {

private boolean streaming;
Expand Down
Loading