Widgets: Use array_all() in WP_Widget_Media_Gallery::has_content()#12609
Widgets: Use array_all() in WP_Widget_Media_Gallery::has_content()#12609Soean wants to merge 3 commits into
Conversation
Flatten the nested conditional into an early return when no IDs are present, and replace the manual foreach loop that verifies every gallery ID resolves to an attachment post with the array_all() function, introduced in PHP 8.4 and available in Core via the polyfill in wp-includes/compat.php since 6.8.0. This makes the intent of the check more explicit without changing behavior.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
Co-authored-by: Mukesh Panchal <mukeshpanchal27@users.noreply.github.com>
Trac Ticket MissingThis pull request is missing a link to a Trac ticket. For a contribution to be considered, there must be a corresponding ticket in Trac. To attach a pull request to a Trac ticket, please include the ticket's full URL in your pull request description. More information about contributing to WordPress on GitHub can be found in the Core Handbook. |
There was a problem hiding this comment.
Pull request overview
This PR refactors WP_Widget_Media_Gallery::has_content() to use Core’s array_all() helper (polyfilled for supported PHP versions) instead of a manual foreach loop, while also flattening the surrounding conditional into an early return.
Changes:
- Replace the manual
foreach/early-return pattern witharray_all()to validate attachment post types. - Convert the outer conditional into an early
return falsewhenidsis empty.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| return array_all( | ||
| $attachments, | ||
| fn( $attachment ) => 'attachment' === get_post_type( $attachment ) |
Description
This PR replaces the manual
foreachloop inWP_Widget_Media_Gallery::has_content()with thearray_all()function, which expresses the same intent — returntrueonly if every attachment ID resolves to a post of typeattachment— without the loop-and-early-return boilerplate.array_all()was introduced in PHP 8.4 and is available in Core for all supported PHP versions via the polyfill inwp-includes/compat.php(since 6.8.0).The surrounding conditional is also flattened into an early return, but that is a minor side effect. No functional change.
Trac ticket:
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.