Skip to content

Customize: Support hiding random default headers#12605

Draft
ArkaPrabhaChowdhury wants to merge 2 commits into
WordPress:trunkfrom
ArkaPrabhaChowdhury:trac-46128-random-header-hide
Draft

Customize: Support hiding random default headers#12605
ArkaPrabhaChowdhury wants to merge 2 commits into
WordPress:trunkfrom
ArkaPrabhaChowdhury:trac-46128-random-header-hide

Conversation

@ArkaPrabhaChowdhury

Copy link
Copy Markdown

Trac ticket: https://core.trac.wordpress.org/ticket/46128

When a theme enables random default header images without setting a fixed default image, the Customizer currently treats the header image setting as empty. This hides the Hide image button even though a randomized header is displayed.

This sets the Customizer setting default to random-default-image when the theme enables random default headers, while preserving the existing fixed default behavior otherwise. Regression coverage verifies both cases.

Testing

  • npm run test:php -- --filter Tests_WP_Customize_Manager::test_header_image_setting_default
  • PHPCS for both changed files
  • PHP syntax checks for both changed files

@github-actions

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant