WI01079276 - Fix QI control regressions#19
Open
lvo-wtg wants to merge 1 commit into
Open
Conversation
… bounds Co-authored-by: Copilot copilot@github.com
wtg-mg8
reviewed
May 29, 2026
|
|
||
| internal partial class DefaultLayout | ||
| { | ||
| private const int MinimumSignificantStretchDelta = 16; |
There was a problem hiding this comment.
Hi @lvo-wtg, where did this new code come from? Is this net8 code we didn't merge properly, something in Microsoft's net10 code we overwrote incorrectly, or AI generated fixes?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we migrate the fork of winforms over to NET10 we introduce regressions with how some of the controls are sized when then extend outside the visible bounds of control element itself in this class
winforms/src/System.Windows.Forms/System/Windows/Forms/Layout/DefaultLayout.AnchorLayoutCompat.cs
Line 4 in 7a15ef7
This PR rescales the control sizes so that they are not out of bounds
Before the PR with the regression (missing button on the buttom right + cancel button cut off):
PR applied:
