feat: add flag to strictly evaluate deterministic metrics#24
Open
ev1lm0nk3y wants to merge 2 commits into
Open
feat: add flag to strictly evaluate deterministic metrics#24ev1lm0nk3y wants to merge 2 commits into
ev1lm0nk3y wants to merge 2 commits into
Conversation
…tic metrics This flag allows benchdiff to bypass benchstat's statistical significance checks for allocs/op and B/op, ensuring that any regression in these metrics exceeding the tolerance threshold triggers a failure.
This allows users to define a separate threshold for regressions in allocs/op and B/op. It defaults to 0.0 as requested.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Running benchmarks within github actions or host that may have multiple users running various workloads can skew any time-based benchmark metrics leading to potential noisy CI failures. Also, this will give benchdiff another tool in its kit.
What This Does
This flag allows benchdiff to bypass benchstat's statistical significance checks for allocs/op and B/op, ensuring that any regression in these metrics exceeding the tolerance threshold triggers a failure.
By default, any regression in these metrics will signal failure but a tolerance can be configured.