Compute effects for indirect calls in GlobalEffects#8609
Open
stevenfontanella wants to merge 10 commits intomainfrom
Open
Compute effects for indirect calls in GlobalEffects#8609stevenfontanella wants to merge 10 commits intomainfrom
stevenfontanella wants to merge 10 commits intomainfrom
Conversation
stevenfontanella
force-pushed
the
indirect-effects-scc
branch
8 times, most recently
from
b7ce0b6 to
9fcf76b
Compare
stevenfontanella
changed the title
stevenfontanella
force-pushed
the
indirect-effects-scc
branch
from
9fcf76b to
0e28a7a
Compare
stevenfontanella
force-pushed
the
indirect-effects-scc
branch
from
0e28a7a to
83f4b3b
Compare
stevenfontanella
force-pushed
the
indirect-effects-scc
branch
from
83f4b3b to
3a25c2e
Compare
kripken
reviewed
Apr 16, 2026
tlively
reviewed
Apr 17, 2026
kripken
reviewed
Apr 17, 2026
tlively
reviewed
Apr 17, 2026
| } | ||
| }; | ||
|
|
||
| // Explicit deduction guide to resolve -Wctad-maybe-unsupported |
Member
There was a problem hiding this comment.
Using ranges turned out to be much more complicated than I thought 😢
Member
There was a problem hiding this comment.
I am not that impressed with the clarity of the Ranges code... but I don't feel strongly if you two like it.
Member
Author
There was a problem hiding this comment.
Totally agreed, this is my first time trying ranges. Disabling -Wctad-maybe-unsupported is an option which would let us remove this but Gemini suggested that the auto-generated deduction guides go wrong sometimes: https://gist.github.com/stevenfontanella/819251700a408d6243f7833acebdad20
Member
There was a problem hiding this comment.
The bigger problem is that google uses that option when compiling this internally.
kripken
reviewed
Apr 17, 2026
kripken
reviewed
Apr 17, 2026
kripken
reviewed
Apr 17, 2026
tlively
reviewed
Apr 18, 2026
Comment on lines
+160
to
+163
| (type $func-with-sub-param (sub (func (param (ref $sub))))) | ||
| ;; Subtype | ||
| ;; CHECK: (type $func-with-super-param (sub $func-with-sub-param (func (param (ref $super))))) | ||
| (type $func-with-super-param (sub $func-with-sub-param (func (param (ref $super))))) |
Member
There was a problem hiding this comment.
You could simplify these tests by getting rid of the struct types and parameters entirely, and just have (type $super (sub (func))) and (type $sub (sub $super (func))).
Comment on lines
+57
to
+59
| ;; Similar to $f, but we may still trap here because the ref is null, so we | ||
| ;; don't optimize. | ||
| (call $calls-nop-via-nullable-ref (local.get $ref)) |
Member
There was a problem hiding this comment.
It would be interesting to test --traps-never-happen mode as well so show that this will be optimized in that case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running in --closed-world, compute effects for indirect calls by unioning the effects of all potential functions of that type. In --closed-world, we assume that all references originate in our module, so the only possible functions that we don't know about are imports. Previously we gave up on effects analysis for indirect calls.
Yields a very small byte count reduction in calcworker (3799354 - 3799297 = 57 bytes). Also shows no significant difference in runtime: (0.1346069 -> 0.13375045 = <1% improvement, probably within noise). We expect more benefits after we're able to share indirect call effects with other passes, since currently they're only seen one layer up for callers of functions that indirectly call functions (see the newly-added tests for examples).
Followups:
Part of #8615.