Skip to content

Update maestro tests for new payment flows#84

Merged
ignaciosantise merged 4 commits intomasterfrom
fix-maestro-tests-pr480
May 6, 2026
Merged

Update maestro tests for new payment flows#84
ignaciosantise merged 4 commits intomasterfrom
fix-maestro-tests-pr480

Conversation

@ignaciosantise
Copy link
Copy Markdown
Contributor

Summary

Why

The wallet PR changed the payment-option navigation and test IDs, so the shared pay flows in WalletConnect/actions needed to be updated to keep the E2E suite aligned.

Validation

  • parsed all 7 edited Maestro YAML files with Ruby YAML.load_file

@claude
Copy link
Copy Markdown

claude Bot commented Apr 30, 2026

Claude encountered an error —— View job


I'll analyze this and get back to you.

@ignaciosantise ignaciosantise changed the title [codex] fix pay maestro flows for pr 480 Update maestro tests for new payment flows May 6, 2026
@ignaciosantise ignaciosantise requested a review from jakubuid May 6, 2026 10:10
@ignaciosantise ignaciosantise marked this pull request as ready for review May 6, 2026 10:21
Copilot AI review requested due to automatic review settings May 6, 2026 10:21
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the shared WalletConnect Pay Maestro E2E flows in maestro/pay-tests to align with the updated WalletKit payment-option navigation and test IDs, keeping downstream Pay E2E suites working after the UX changes.

Changes:

  • Update multi-option flows to use the new select-option header ID and remove stale *-selected / pay-button-continue selectors.
  • Switch “info required” assertions to the new pay-option-info-required test ID for KYC/no-KYC coverage.
  • Loosen pay-button amount assertions from an exact match to a prefix check (Pay $…) and add clearState to several pay flows.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.

Show a summary per file
File Description
maestro/pay-tests/.maestro/pay_single_option_nokyc.yaml Adds clearState and loosens pay-button amount assertion for single-option no-KYC flow.
maestro/pay-tests/.maestro/pay_single_option_nokyc_deeplink.yaml Adds clearState and loosens pay-button amount assertion for deep-linked single-option no-KYC flow.
maestro/pay-tests/.maestro/pay_multiple_options_nokyc.yaml Updates selectors/navigation for multi-option no-KYC flow; switches to new “info required” marker ID and loosens pay-button assertion.
maestro/pay-tests/.maestro/pay_multiple_options_kyc.yaml Updates selectors/navigation for multi-option KYC flow; switches to new “info required” marker ID and loosens pay-button assertion.
maestro/pay-tests/.maestro/pay_kyc_back_navigation.yaml Updates KYC back-navigation flow to use new select-option header ID and option-tap navigation.
maestro/pay-tests/.maestro/pay_double_scan.yaml Loosens pay-button amount assertion for the double-scan flow.
maestro/pay-tests/.maestro/pay_cancel_from_kyc.yaml Updates cancel-from-KYC flow to use new select-option header ID and option-tap navigation.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ignaciosantise ignaciosantise merged commit e055fc0 into master May 6, 2026
8 checks passed
@ignaciosantise ignaciosantise deleted the fix-maestro-tests-pr480 branch May 6, 2026 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants