Update maestro tests for new payment flows#84
Merged
ignaciosantise merged 4 commits intomasterfrom May 6, 2026
Merged
Conversation
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
jakubuid
approved these changes
May 6, 2026
There was a problem hiding this comment.
Pull request overview
This PR updates the shared WalletConnect Pay Maestro E2E flows in maestro/pay-tests to align with the updated WalletKit payment-option navigation and test IDs, keeping downstream Pay E2E suites working after the UX changes.
Changes:
- Update multi-option flows to use the new select-option header ID and remove stale
*-selected/pay-button-continueselectors. - Switch “info required” assertions to the new
pay-option-info-requiredtest ID for KYC/no-KYC coverage. - Loosen pay-button amount assertions from an exact match to a prefix check (
Pay $…) and addclearStateto several pay flows.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| maestro/pay-tests/.maestro/pay_single_option_nokyc.yaml | Adds clearState and loosens pay-button amount assertion for single-option no-KYC flow. |
| maestro/pay-tests/.maestro/pay_single_option_nokyc_deeplink.yaml | Adds clearState and loosens pay-button amount assertion for deep-linked single-option no-KYC flow. |
| maestro/pay-tests/.maestro/pay_multiple_options_nokyc.yaml | Updates selectors/navigation for multi-option no-KYC flow; switches to new “info required” marker ID and loosens pay-button assertion. |
| maestro/pay-tests/.maestro/pay_multiple_options_kyc.yaml | Updates selectors/navigation for multi-option KYC flow; switches to new “info required” marker ID and loosens pay-button assertion. |
| maestro/pay-tests/.maestro/pay_kyc_back_navigation.yaml | Updates KYC back-navigation flow to use new select-option header ID and option-tap navigation. |
| maestro/pay-tests/.maestro/pay_double_scan.yaml | Loosens pay-button amount assertion for the double-scan flow. |
| maestro/pay-tests/.maestro/pay_cancel_from_kyc.yaml | Updates cancel-from-KYC flow to use new select-option header ID and option-tap navigation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
*-selectedandpay-button-continueselectors from multi-option/KYC flowspay-option-info-requiredtest IDWhy
The wallet PR changed the payment-option navigation and test IDs, so the shared pay flows in
WalletConnect/actionsneeded to be updated to keep the E2E suite aligned.Validation
YAML.load_file