Skip to content

Fix/formgroup bootstrap5#37

Merged
Vitexus merged 2 commits into
mainfrom
fix/formgroup-bootstrap5
Jun 9, 2026
Merged

Fix/formgroup bootstrap5#37
Vitexus merged 2 commits into
mainfrom
fix/formgroup-bootstrap5

Conversation

@Vitexus

@Vitexus Vitexus commented Jun 9, 2026

Copy link
Copy Markdown
Member

No description provided.

Vitexus and others added 2 commits June 4, 2026 00:18
… in collapse

Three bugs in Navbar.php:
- leftContent had ms-auto (margin-left: auto) which mis-aligned nav items right;
  changed to no auto-margin so items stay left-aligned naturally
- rightContent had ml-auto (Bootstrap 4 class, removed in BS5); updated to
  ms-auto so right-placed items are pushed to the far right
- navBarCollapse() only wrapped leftContent; rightContent was never rendered;
  both ULs are now included so addMenuItem(..., 'right') items actually appear

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Replace the stale Bootstrap 4 carry-over with a proper Bootstrap 5
widget: .mb-3 wrapper, .form-label label and .form-text helper text.

Restore the flexible ($label, $content, $placeholder, $helptext,
$addTagClass) signature used across callers. The previous strict
3-arg, Input-typed constructor threw on label-only/no-arg calls,
non-Input content (ATag, SelectTag) and the 4-arg helptext form,
and referenced a non-existent Ease\TWB5\DivTag.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@Vitexus Vitexus merged commit 9bc70c6 into main Jun 9, 2026
0 of 2 checks passed
@coderabbitai

coderabbitai Bot commented Jun 9, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@Vitexus, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 57 minutes and 47 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 2647b99f-ac00-4aff-b637-79311f40dc3f

📥 Commits

Reviewing files that changed from the base of the PR and between c47ae13 and a3f6849.

📒 Files selected for processing (2)
  • src/Ease/TWB5/FormGroup.php
  • src/Ease/TWB5/Navbar.php
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/formgroup-bootstrap5

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Vitexus Vitexus deleted the fix/formgroup-bootstrap5 branch June 9, 2026 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant