Skip to content

i18n: add Korean (ko) translation#630

Open
moduvoice wants to merge 1 commit into
ValueCell-ai:mainfrom
moduvoice:i18n/add-korean
Open

i18n: add Korean (ko) translation#630
moduvoice wants to merge 1 commit into
ValueCell-ai:mainfrom
moduvoice:i18n/add-korean

Conversation

@moduvoice

Copy link
Copy Markdown

Motivation

This adds Korean (ko) translation support — to help Korean-speaking users use this
open-source project more comfortably in their own language.

한국 사람들의 오픈소스 이용에 도움이 되게 하기 위해서 한글화 작업을 하였습니다.

Changes

  • Added frontend/src/i18n/locales/ko.json with full Korean translation (273 keys, 1:1 parity with en.json)
  • Registered the new locale in frontend/src/i18n/index.ts (i18next resources)
  • Added a ko option label ("한국어") to the language switcher in each existing locale file (en.json, ja.json, zh_CN.json, zh_TW.json) — no other strings in these files were touched
  • Added the ko SelectItem to the language dropdown in frontend/src/app/setting/general.tsx
  • Extended LanguageCode and browser-language auto-detection (ko-KRko) in frontend/src/store/settings-store.ts
  • Mapped ko to the <html lang> attribute (ko) in frontend/src/root.tsx

Testing

  • Programmatically verified ko.json has exact key parity with en.json (273/273 keys, no missing/extra)
  • Confirmed the diffs to en.json/ja.json/zh_CN.json/zh_TW.json are limited to the single new ko option-label line
  • Ran bun run check:fix (Biome) — no issues, no fixes applied
  • Ran bun run typecheck — passes with no errors
  • Manually reviewed the Korean translations for trading/fintech terminology (레버리지, 손익, 실전/모의 매매, 강제 청산, etc.) for natural phrasing

Add frontend/src/i18n/locales/ko.json with a complete Korean
translation of all UI strings, matching the existing en/ja/zh_CN/zh_TW
structure key-for-key. Register the new locale across the language
switcher: i18n resources (i18n/index.ts), LanguageCode type and
browser-locale detection (store/settings-store.ts), the language
select in Settings > General (app/setting/general.tsx), the <html
lang> mapping (root.tsx), and the self-referential "ko" option label
added to every existing locale file.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant