Skip to content

ci(e2e): clarify Stripe test skip message for fork PRs#1200

Merged
superdav42 merged 1 commit into
mainfrom
fix/e2e-stripe-fork-skip-message
May 12, 2026
Merged

ci(e2e): clarify Stripe test skip message for fork PRs#1200
superdav42 merged 1 commit into
mainfrom
fix/e2e-stripe-fork-skip-message

Conversation

@superdav42
Copy link
Copy Markdown
Collaborator

Summary

Improves the message printed when the E2E workflow skips the Stripe tests, so
the cause is obvious from the run log.

Why

When a PR is opened from a forked repository, GitHub Actions intentionally
does not expose repo secrets (STRIPE_TEST_PK_KEY, STRIPE_TEST_SK_KEY) to
the workflow run. This is a security feature, not a misconfiguration.

The previous skip message ("STRIPE_TEST_SK_KEY secret not configured") implied
the secret was missing at the repo level, which led to wasted investigation
time — the secret was configured (verifiable via gh secret list).

Evidence

Run 25765984372
(PR from fork kenedytorcatt/ultimate-multisite) — Stripe step env block:

env:
  STRIPE_TEST_PK_KEY: 
  STRIPE_TEST_SK_KEY: 

Run 25762586860
(push to main) — same step:

env:
  STRIPE_TEST_SK_KEY: ***

Both secrets are present in gh secret list --repo Ultimate-Multisite/ultimate-multisite.

Change

Single workflow file: .github/workflows/e2e.yml. The skip message now
explains the fork-PR security behaviour, lists when Stripe tests will run
(push to main, or PRs from upstream branches), and points to gh secret list
for local verification. No logic change — the same exit 0 path runs when the
key is empty.

Verification

  • YAML syntax validated with python3 -c "import yaml; yaml.safe_load(...)".
  • No behavioural change: the gate condition and exit code are unchanged.
  • Once merged to main, the Stripe step on this push event will run as before
    (secrets exposed), confirming the gate still passes when secrets are available.

aidevops.sh v3.15.38 plugin for OpenCode v1.14.48 with gpt-5.5 spent 5h 32m and 15,815 tokens on this as a headless worker.

The previous message ('STRIPE_TEST_SK_KEY secret not configured') was
misleading on PRs from forked repos, where the secret IS configured at
the repo level but is intentionally not exposed by GitHub Actions to
fork-PR workflow runs.

Explain that this is expected GitHub security behaviour, list when the
Stripe tests will actually run (push to main, or PRs from upstream
branches), and point to gh secret list for local verification.
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 12, 2026

Warning

Rate limit exceeded

@superdav42 has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 16 minutes and 15 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 80bd6188-bfec-4756-bb3d-37332b989b5d

📥 Commits

Reviewing files that changed from the base of the PR and between ddd628c and 2201392.

📒 Files selected for processing (1)
  • .github/workflows/e2e.yml
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/e2e-stripe-fork-skip-message

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@superdav42 superdav42 merged commit 54fb622 into main May 12, 2026
10 of 11 checks passed
@superdav42
Copy link
Copy Markdown
Collaborator Author

Summary

Improves the message printed when the E2E workflow skips the Stripe tests, so
the cause is obvious from the run log.

Why

When a PR is opened from a forked repository, GitHub Actions intentionally
does not expose repo secrets (STRIPE_TEST_PK_KEY, STRIPE_TEST_SK_KEY) to
the workflow run. This is a security feature, not a misconfiguration.
The previous skip message ("STRIPE_TEST_SK_KEY secret not configured") implied
the secret was missing at the repo level, which led to wasted investigation
time — the secret was configured (verifiable via gh secret list).

Evidence

Run 25765984372
(PR from fork kenedytorcatt/ultimate-multisite) — Stripe step env block:

env:
  STRIPE_TEST_PK_KEY: 
  STRIPE_TEST_SK_KEY: 

Run 25762586860
(push to main) — same step:

env:
  STRIPE_TEST_SK_KEY: ***

Both secrets are present in gh secret list --repo Ultimate-Multisite/ultimate-multisite.

Change

Single workflow file: .github/workflows/e2e.yml. The skip message now
explains the fork-PR security behaviour, lists when Stripe tests will run
(push to main, or PRs from upstream branches), and points to gh secret list
for local verification. No logic change — the same exit 0 path runs when the
key is empty.

Verification

  • YAML syntax validated with python3 -c "import yaml; yaml.safe_load(...)".
  • No behavioural change: the gate condition and exit code are unchanged.
  • Once merged to main, the Stripe step on this push event will run as before
    (secrets exposed), confirming the gate still passes when secrets are available.

aidevops.sh v3.15.38 plugin for OpenCode v1.14.48 with gpt-5.5 spent 5h 32m and 15,815 tokens on this as a headless worker.


Merged via PR #1200 to main.
Merged by deterministic merge pass (pulse-wrapper.sh).

@github-actions
Copy link
Copy Markdown

Performance Test Results

Performance test results for e394589 are in 🛎️!

Note: the numbers in parentheses show the difference to the previous (baseline) test run. Differences below 2% or 0.5 in absolute values are not shown.

URL: /

Run DB Queries Memory Before Template Template WP Total LCP TTFB LCP - TTFB
0 40 (-1 / -3% ) 37.75 MB 858.50 ms (-25.00 ms / -3% ) 162.00 ms 1077.50 ms 2014.00 ms (-88.00 ms / -4% ) 1909.85 ms (-106.15 ms / -6% ) 91.70 ms (-2.25 ms / -2% )
1 56 49.14 MB 972.50 ms 151.50 ms 1126.00 ms 2112.00 ms 2028.50 ms 81.95 ms (-3.05 ms / -4% )

@superdav42 superdav42 added the review-feedback-scanned Merged PR already scanned for quality feedback label May 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review-feedback-scanned Merged PR already scanned for quality feedback

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant