Skip to content

Used correct type when posts aren't rescheduled#27435

Draft
EvanHahn wants to merge 1 commit intoseparate-scheduling-and-post-schedulingfrom
use-correct-type-for-post-scheduling-when-not-doing-anything-on-boot
Draft

Used correct type when posts aren't rescheduled#27435
EvanHahn wants to merge 1 commit intoseparate-scheduling-and-post-schedulingfrom
use-correct-type-for-post-scheduling-when-not-doing-anything-on-boot

Conversation

@EvanHahn
Copy link
Copy Markdown
Contributor

no ref

This change should have no user impact.

PostSchedulerService expects the list of scheduled resources to be an object, but we sometimes pass it an array. It turns out that was fine in this case (it was using Object.keys() which happens to behave the same), but that's not what we intended. Let's fix that.

no ref

This change should have no user impact.

`PostSchedulerService` expects the list of scheduled resources to be an
object, but we sometimes pass it an array. It turns out that was fine in
this case (it was using `Object.keys()` which happens to behave the
same), but that's not what we intended. Let's fix that.
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 16, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 202cd4d8-5eff-4145-9478-d7badc969cf2

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch use-correct-type-for-post-scheduling-when-not-doing-anything-on-boot

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud
Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant