Skip to content

chore: merge rest-definition with definition#2343

Open
rsynek wants to merge 1 commit into
TimefoldAI:mainfrom
rsynek:chore/merge-modules
Open

chore: merge rest-definition with definition#2343
rsynek wants to merge 1 commit into
TimefoldAI:mainfrom
rsynek:chore/merge-modules

Conversation

@rsynek

@rsynek rsynek commented Jun 8, 2026

Copy link
Copy Markdown
Collaborator

Merged rest-definition into definition.

Motivation: 3 classes are not worth keeping in a separate module, if we don't require their separation from other reasons.

Motivation: not worth to keep 3 classes in a separate module,
if we don't require their separation from other reasons.
@sonarqubecloud

sonarqubecloud Bot commented Jun 8, 2026

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 70%)

See analysis details on SonarQube Cloud

@rsynek rsynek marked this pull request as ready for review June 9, 2026 13:49
@rsynek rsynek requested a review from triceo as a code owner June 9, 2026 13:49
Copilot AI review requested due to automatic review settings June 9, 2026 13:49

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the model/rest-definition module by moving its REST API “definition” types into model/definition and updating downstream modules to import them from the new location.

Changes:

  • Moved REST definition types (OperationId, OperationOnPost, DatasetSelector) into timefold-solver-model-definition under ai.timefold.solver.model.definition.api.rest.
  • Updated REST implementation, Quarkus deployment processor, and tests to use the new imports.
  • Removed the timefold-solver-model-rest-definition Maven module and its BOM entries/dependencies.

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.

Show a summary per file
File Description
model/test-model/src/test/java/ai/timefold/solver/model/testmodel/OpenApiTest.java Updates import to new definition.api.rest package.
model/test-model/src/test/java/ai/timefold/solver/model/testmodel/EmployeeScheduleResourceTest.java Updates import to new definition.api.rest package.
model/rest/src/main/java/ai/timefold/solver/model/rest/impl/AbstractModelAPIResource.java Switches REST resource implementation to use the moved REST definition types.
model/rest/pom.xml Drops dependency on removed timefold-solver-model-rest-definition module.
model/rest-definition/pom.xml Deletes the rest-definition module POM (module removed).
model/quarkus/deployment/src/main/java/ai/timefold/solver/model/quarkus/deployment/TimefoldModelDescriptorProcessor.java Updates imports/static import to new definition.api.rest.OperationId.
model/pom.xml Removes rest-definition from the Maven reactor modules list.
model/definition/src/main/java/ai/timefold/solver/model/definition/api/rest/OperationOnPost.java Moves type to new package.
model/definition/src/main/java/ai/timefold/solver/model/definition/api/rest/OperationId.java Moves type to new package.
model/definition/src/main/java/ai/timefold/solver/model/definition/api/rest/DatasetSelector.java Moves type to new package.
build/bom/pom.xml Removes BOM-managed dependency entries for the removed artifact.
Comments suppressed due to low confidence (1)

model/definition/src/main/java/ai/timefold/solver/model/definition/api/rest/OperationId.java:1

  • The PR description only mentions merging modules, but changing these types’ package (and therefore their fully-qualified names) is a breaking public API change, so either keep the original package names or provide deprecated bridge types (and document the migration).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants