chore: merge rest-definition with definition#2343
Open
rsynek wants to merge 1 commit into
Open
Conversation
Motivation: not worth to keep 3 classes in a separate module, if we don't require their separation from other reasons.
|
triceo
approved these changes
Jun 9, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the model/rest-definition module by moving its REST API “definition” types into model/definition and updating downstream modules to import them from the new location.
Changes:
- Moved REST definition types (
OperationId,OperationOnPost,DatasetSelector) intotimefold-solver-model-definitionunderai.timefold.solver.model.definition.api.rest. - Updated REST implementation, Quarkus deployment processor, and tests to use the new imports.
- Removed the
timefold-solver-model-rest-definitionMaven module and its BOM entries/dependencies.
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| model/test-model/src/test/java/ai/timefold/solver/model/testmodel/OpenApiTest.java | Updates import to new definition.api.rest package. |
| model/test-model/src/test/java/ai/timefold/solver/model/testmodel/EmployeeScheduleResourceTest.java | Updates import to new definition.api.rest package. |
| model/rest/src/main/java/ai/timefold/solver/model/rest/impl/AbstractModelAPIResource.java | Switches REST resource implementation to use the moved REST definition types. |
| model/rest/pom.xml | Drops dependency on removed timefold-solver-model-rest-definition module. |
| model/rest-definition/pom.xml | Deletes the rest-definition module POM (module removed). |
| model/quarkus/deployment/src/main/java/ai/timefold/solver/model/quarkus/deployment/TimefoldModelDescriptorProcessor.java | Updates imports/static import to new definition.api.rest.OperationId. |
| model/pom.xml | Removes rest-definition from the Maven reactor modules list. |
| model/definition/src/main/java/ai/timefold/solver/model/definition/api/rest/OperationOnPost.java | Moves type to new package. |
| model/definition/src/main/java/ai/timefold/solver/model/definition/api/rest/OperationId.java | Moves type to new package. |
| model/definition/src/main/java/ai/timefold/solver/model/definition/api/rest/DatasetSelector.java | Moves type to new package. |
| build/bom/pom.xml | Removes BOM-managed dependency entries for the removed artifact. |
Comments suppressed due to low confidence (1)
model/definition/src/main/java/ai/timefold/solver/model/definition/api/rest/OperationId.java:1
- The PR description only mentions merging modules, but changing these types’ package (and therefore their fully-qualified names) is a breaking public API change, so either keep the original package names or provide deprecated bridge types (and document the migration).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Merged
rest-definitionintodefinition.Motivation: 3 classes are not worth keeping in a separate module, if we don't require their separation from other reasons.