Add Gaussian Naive Bayes classifier in machine_learning/#14853
Open
PRERITARYA wants to merge 2 commits into
Open
Add Gaussian Naive Bayes classifier in machine_learning/#14853PRERITARYA wants to merge 2 commits into
PRERITARYA wants to merge 2 commits into
Conversation
for more information, see https://pre-commit.ci
algorithms-keeper
Bot
added
awaiting reviews
![algorithms-keeper[bot]](https://avatars.githubusercontent.com/in/235834?s=60&v=4){kind=small}
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
|
|
||
| return priors, summaries | ||
|
|
||
|
|
There was a problem hiding this comment.
Please provide descriptive name for the parameter: x
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a from-scratch Gaussian Naive Bayes classifier implementation under machine_learning/, intended to provide a lightweight probabilistic classifier without external ML dependencies.
Changes:
- Introduces training helpers to compute per-class priors and per-feature Gaussian summaries (mean/variance).
- Implements log-space Gaussian likelihood scoring for stable prediction.
- Adds doctests for core helpers and an executable
doctest.testmod()entrypoint.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+147
to
+161
| n_samples = len(data) | ||
| separated = separate_by_class(data, labels) | ||
|
|
||
| priors: dict[int, float] = {} | ||
| summaries: dict[int, list[tuple[float, float]]] = {} | ||
|
|
||
| for class_label, class_samples in separated.items(): | ||
| priors[class_label] = math.log(len(class_samples) / n_samples) | ||
| # transpose to get per-feature lists | ||
| features_by_column = [ | ||
| [row[col] for row in class_samples] for col in range(len(class_samples[0])) | ||
| ] | ||
| summaries[class_label] = [ | ||
| compute_mean_variance(column) for column in features_by_column | ||
| ] |
Comment on lines
+226
to
+229
| for class_label, feature_summaries in summaries.items(): | ||
| score = priors[class_label] | ||
| for feature_value, (mean, variance) in zip(feature_vector, feature_summaries): | ||
| score += gaussian_log_probability(feature_value, mean, variance) |
Comment on lines
+302
to
+305
| if not predictions: | ||
| raise ValueError("Inputs must not be empty.") | ||
| if len(predictions) != len(actual): | ||
| raise ValueError("Predictions and actual labels must have the same length.") |
Comment on lines
+24
to
+25
| Time Complexity: O(n * k * d) for training, O(k * d) for prediction | ||
| where n = samples, k = classes, d = features |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your change:
Add Gaussian Naive Bayes classifier implemented from scratch without any
external ML libraries (no sklearn).
Implements the full pipeline:
separate_by_class: splits training data by class labelcompute_mean_variance: computes per-feature Gaussian statisticstrain: fits priors and per-class feature summariesgaussian_log_probability: evaluates the Gaussian PDF in log spacepredict/predict_single: classifies new samplesaccuracy: evaluates classifier performanceChecklist: