est: check if delay calculator supports reduceParasitics#10554
Open
eder-matheus wants to merge 9 commits into
Open
est: check if delay calculator supports reduceParasitics#10554eder-matheus wants to merge 9 commits into
eder-matheus wants to merge 9 commits into
Conversation
Signed-off-by: Eder Monteiro <emrmonteiro@precisioninno.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request wraps parasitic reduction and deletion calls inside a check to arc_delay_calc_->reduceSupported(). The reviewer recommends also checking if arc_delay_calc_ is not null before calling reduceSupported() to prevent potential null pointer dereferences.
maliberty
approved these changes
May 29, 2026
Member
Author
|
CI is running. |
Signed-off-by: Eder Monteiro <emrmonteiro@precisioninno.com>
Avoids a singular conductance matrix in delay calculators that solve the parasitic network directly (Prima/CCS) when a pin coincides with its grid node. Matches the 1 mOhm floor convention already used by other resistors in this file. Signed-off-by: Eder Monteiro <emrmonteiro@precisioninno.com>
Both getPlanarRoute and get3DRoute emit GSegments per Steiner edge independently. At branch points where two edges arrive on different layers, no bridging via is emitted, leaving the GRoute electrically disconnected at that XY -- pi-Elmore reducers absorb this silently but delay calculators that solve the parasitic network directly (Prima/CCS) see disconnected sub-trees and fail with a singular conductance matrix. Track the layer last committed at each XY in the emitted route and add an explicit via when a later edge arrives on a different layer. Signed-off-by: Eder Monteiro <emrmonteiro@precisioninno.com>
…ate/OpenROAD into est_check_delay_calc
Member
Author
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0a9153c344
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
bridge_and_record (in both getPlanarRoute and get3DRoute) emitted a single via segment whenever the recorded and new layers differed, which produces a non-physical multi-cut-layer via at Steiner points where one edge already laid down a full via stack. The route writer rejects such segments with GRT-75. Guard the bridge emission on adjacent-layer gaps only; wider gaps are covered by the existing stack. Signed-off-by: Eder Monteiro <emrmonteiro@precisioninno.com>
Signed-off-by: Eder Monteiro <emrmonteiro@precisioninno.com>
Signed-off-by: Eder Monteiro <emrmonteiro@precisioninno.com>
Signed-off-by: Eder Monteiro <emrmonteiro@precisioninno.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updated placement and routing parasitics estimation with checks for delay calculator support for reduce parasitics. This is especially important when using STA's
set_delay_calculator primaand CCS libraries.Type of Change
Impact
Correct parasitics estimation for CCS designs.
Verification
./etc/Build.sh).