Skip to content

updates for EST fixes#4271

Merged
maliberty merged 4 commits into
The-OpenROAD-Project:masterfrom
The-OpenROAD-Project-staging:secure-est_check_delay_calc
Jun 1, 2026
Merged

updates for EST fixes#4271
maliberty merged 4 commits into
The-OpenROAD-Project:masterfrom
The-OpenROAD-Project-staging:secure-est_check_delay_calc

Conversation

@eder-matheus
Copy link
Copy Markdown
Member

@eder-matheus eder-matheus commented Jun 1, 2026

designs/asap7/gcd-ccs/rules-base.json updates:

Metric Old New Type
cts__timing__setup__ws -63.5 -79.2 Failing
cts__timing__setup__tns -773.0 -1260.0 Failing
globalroute__timing__setup__ws -63.5 -93.7 Failing
globalroute__timing__setup__tns -771.0 -1530.0 Failing
finish__timing__setup__ws -84.2 -78.5 Tighten
finish__timing__setup__tns -1200.0 -1190.0 Tighten

Signed-off-by: Eder Monteiro <emrmonteiro@precisioninno.com>
…ate/OpenROAD-flow-scripts into secure-est_check_delay_calc

Signed-off-by: Eder Monteiro <emrmonteiro@precisioninno.com>
Signed-off-by: Eder Monteiro <emrmonteiro@precisioninno.com>
Signed-off-by: Eder Monteiro <emrmonteiro@precisioninno.com>
@eder-matheus eder-matheus self-assigned this Jun 1, 2026
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request lowers the core utilization for the gcd-ccs design to address a DPL failure, updates the tools/OpenROAD subproject commit, and updates the regression baselines in rules-base.json. However, the updated baselines show a significant degradation in timing metrics (e.g., cts__timing__setup__tns and globalroute__timing__setup__tns). Please ensure that this degradation is documented with an explicit agreement or a tracking issue as required by the repository guidelines.

},
"cts__timing__setup__tns": {
"value": -773.0,
"value": -1260.0,
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The timing metrics show a significant degradation (e.g., cts__timing__setup__tns degrading from -773.0 to -1260.0 and globalroute__timing__setup__tns from -771.0 to -1530.0). Per the repository guidelines, merging updates to regression baselines with significant degradation is acceptable only if there is an explicit agreement or tracking issue to address the underlying timing issue later. Please document this agreement or reference the tracking issue in the PR description.

References
  1. It is acceptable to merge updates to regression baselines that show significant degradation, provided there is an explicit agreement to address the underlying issue later.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This large degradations are explained by the fixes on the estimate_parasitics command. For this design, which uses set_delay_calculator prima, wire delay was always zero due to a bug. Now we're properly estimating parasitics for it.

@eder-matheus eder-matheus requested a review from maliberty June 1, 2026 18:42
@maliberty maliberty merged commit 9f23156 into The-OpenROAD-Project:master Jun 1, 2026
8 checks passed
@maliberty maliberty deleted the secure-est_check_delay_calc branch June 1, 2026 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants