Skip to content

Update metrics after CTS NDR spacing fix#4261

Merged
maliberty merged 3 commits into
The-OpenROAD-Project:masterfrom
The-OpenROAD-Project-staging:update_metrics_cts_ndr_fix
May 28, 2026
Merged

Update metrics after CTS NDR spacing fix#4261
maliberty merged 3 commits into
The-OpenROAD-Project:masterfrom
The-OpenROAD-Project-staging:update_metrics_cts_ndr_fix

Conversation

@jfgava
Copy link
Copy Markdown
Contributor

@jfgava jfgava commented May 27, 2026

designs/sky130hd/chameleon/rules-base.json updates:

Metric Old New Type
globalroute__antenna_diodes_count 196 198 Failing
finish__timing__setup__tns -7.36 -8.03 Failing

designs/sky130hd/microwatt/rules-base.json updates:

Metric Old New Type
globalroute__antenna_diodes_count 1426 1499 Failing
detailedroute__antenna__violating__nets 1 4 Failing
detailedroute__antenna_diodes_count 1384 1416 Failing
finish__timing__setup__ws -2.71 -2.7 Tighten
finish__timing__hold__ws -1.6 -1.0 Tighten
finish__timing__hold__tns -15.3 -6.73 Tighten

designs/nangate45/swerv/rules-base.json updates:

Metric Old New Type
finish__timing__setup__tns -516.0 -619.0 Failing

designs/nangate45/tinyRocket/rules-base.json updates:

Metric Old New Type
finish__timing__setup__tns -46.0 -46.6 Failing

Need #10497

jfgava added 3 commits May 22, 2026 23:11
Signed-off-by: Jonas Gava <jfgava@precisioninno.com>
Signed-off-by: Jonas Gava <jfgava@precisioninno.com>
Signed-off-by: Jonas Gava <jfgava@precisioninno.com>
@jfgava jfgava self-assigned this May 27, 2026
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the OpenROAD subproject commit and adjusts the regression baselines (rules-base.json) for several designs, including swerv, tinyRocket, chameleon, and microwatt. The review feedback highlights significant performance degradations in the updated baselines: specifically, a 20% degradation in setup TNS for the swerv design and a substantial increase in antenna violating nets (from 1 to 4) for the microwatt design. Per repository guidelines, tracking issues should be created to address these degradations before or after merging.

Comment thread flow/designs/nangate45/swerv/rules-base.json
Comment thread flow/designs/sky130hd/microwatt/rules-base.json
@jfgava jfgava requested a review from maliberty May 28, 2026 18:04
@maliberty maliberty merged commit 0572c88 into The-OpenROAD-Project:master May 28, 2026
8 checks passed
@maliberty maliberty deleted the update_metrics_cts_ndr_fix branch May 28, 2026 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants