Fix build with Boost 1.9x, Stormlib crash#470
Conversation
…nly since 1.89 and has been just a empty dummy library since 1.69 (cherry picked from commit c87a004a1688f5dfe463493fbcd47027ea1dcf2e)
|
How did you reproduce the crash? |
|
Goodmorning,
This occurs when running mapextractor normally as usual (compiled as RelWithDeb! Perhaps this is good info). After closing it creates a dump> |
|
So for now I would like you to open a separate PR for the boost commit - that one can go in right away. As for StormLib, I am currently not able to reproduce the mentioned issues on Linux, so there must be some Windows shenanigans going on. I wonder if it really is necessary to alter stormlib itself rather than trying to find a way in the extractor code |
|
unknown_mapextractor.exe_[5-7_8-57-53].txt @brian8544 PS E:\WoWRegeneration-main\Binary\WoW434-15595> .\mapextractor.exe /__ \ __ _/\ _ Detected locale: enUS Loading enUS locale MPQs Detected client build: 15595 |
Changes proposed:
SFileFindFirstFilein mapextractorIssues addressed: Fixes #
Tests performed: (Does it build, tested in-game, etc):
Known issues and TODO list: