Skip to content

Fix build with Boost 1.9x, Stormlib crash#470

Closed
brian8544 wants to merge 3 commits into
The-Cataclysm-Preservation-Project:masterfrom
brian8544:master
Closed

Fix build with Boost 1.9x, Stormlib crash#470
brian8544 wants to merge 3 commits into
The-Cataclysm-Preservation-Project:masterfrom
brian8544:master

Conversation

@brian8544

Copy link
Copy Markdown

Changes proposed:

Issues addressed: Fixes #

Tests performed: (Does it build, tested in-game, etc):

  • Build as RelWithDeb in Visual Studio 2026.
  • Ran mapextractor.exe > pastebin logs

Known issues and TODO list:

  • Verify compatibility with Linux/Unix/Etc

Shauren and others added 3 commits June 23, 2026 22:45
…nly since 1.89 and has been just a empty dummy library since 1.69

(cherry picked from commit c87a004a1688f5dfe463493fbcd47027ea1dcf2e)
@Ovahlord

Copy link
Copy Markdown
Member

How did you reproduce the crash?

@brian8544

brian8544 commented Jun 24, 2026

Copy link
Copy Markdown
Author

Goodmorning,

strcpy(hs->szSearchMask, szMask); always causes:
0db289b51787+mapextractor.exe[24-6_8-4-48].txt

This occurs when running mapextractor normally as usual (compiled as RelWithDeb! Perhaps this is good info). After closing it creates a dump>

Microsoft Windows [Version 10.0.26200.8655]
(c) Microsoft Corporation. All rights reserved.

E:\Games\World of Warcraft - Cataclysm (4.3.4)>mapextractor
TrinityCore rev. 0db289b51787+ 2026-06-23 22:55:13 +0200 (master branch) (Win64, RelWithDebInfo, Static) (Map & DBC Extractor)
<Ctrl-C> to stop.

 ______                       __
/\__  _\       __          __/\ \__
\/_/\ \/ _ __ /\_\    ___ /\_\ \, _\  __  __
   \ \ \/\`'__\/\ \ /' _ `\/\ \ \ \/ /\ \/\ \
    \ \ \ \ \/ \ \ \/\ \/\ \ \ \ \ \_\ \ \_\ \
     \ \_\ \_\  \ \_\ \_\ \_\ \_\ \__\\/`____ \
      \/_/\/_/   \/_/\/_/\/_/\/_/\/__/ `/___/> \
                                 C O R E  /\___/
http://TrinityCore.org                    \/__/

Detected locale: enGB

Loading enGB locale MPQs
Loaded E:\Games\World of Warcraft - Cataclysm (4.3.4)/Data/enGB/wow-update-enGB-15211.MPQ
Loaded E:\Games\World of Warcraft - Cataclysm (4.3.4)/Data/enGB/wow-update-enGB-15354.MPQ
Loaded E:\Games\World of Warcraft - Cataclysm (4.3.4)/Data/enGB/wow-update-enGB-15595.MPQ

Detected client build: 15595
Extracting dbc files...

@Ovahlord

Copy link
Copy Markdown
Member

So for now I would like you to open a separate PR for the boost commit - that one can go in right away.

As for StormLib, I am currently not able to reproduce the mentioned issues on Linux, so there must be some Windows shenanigans going on. I wonder if it really is necessary to alter stormlib itself rather than trying to find a way in the extractor code

@yijian550

yijian550 commented Jul 4, 2026

Copy link
Copy Markdown

unknown_mapextractor.exe_[5-7_8-57-53].txt

@brian8544
Hi, Brian,
I fix the VS link issue by following your modify comments, but I didn't fix the mapextractor.exe crashed issue, see attached logs file, what the problem is it maybe? thanks.

PS E:\WoWRegeneration-main\Binary\WoW434-15595> .\mapextractor.exe
TrinityCore rev. unknown 1970-01-01 00:00:00 +0000 (Archived branch) (Win64, RelWithDebInfo, Static) (Map & DBC Extractor)
to stop.


/__ \ __ _/\ _
/
/\ / _ __ /_\ ___ /_\ , \ __ __
\ \ /`'__/\ \ /' _ \/\ \ \ \/ /\ \/\ \ \ \ \ \ \/ \ \ \/\ \/\ \ \ \ \ \_\ \ \_\ \ \ \_\ \_\ \ \_\ \_\ \_\ \_\ \__\\/
___
//// ////////// `//>
C O R E /_
/
http://TrinityCore.org /
_/

Detected locale: enUS

Loading enUS locale MPQs
Loaded E:\WoWRegeneration-main\Binary\WoW434-15595/Data/enUS/wow-update-enUS-15211.MPQ
Loaded E:\WoWRegeneration-main\Binary\WoW434-15595/Data/enUS/wow-update-enUS-15354.MPQ
Loaded E:\WoWRegeneration-main\Binary\WoW434-15595/Data/enUS/wow-update-enUS-15595.MPQ

Detected client build: 15595
Extracting dbc files...
PS E:\WoWRegeneration-main\Binary\WoW434-15595>

@brian8544 brian8544 closed this Jul 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants