Adds persistence to registrations and categories#20
Open
madsthom wants to merge 1 commit into
Open
Conversation
madsthom
requested review from
AndersSpringborg
and removed request for
AndersSpringborg
|
✔️ Deploy Preview for business-assistant ready! 🔨 Explore the source changes: 7038a52 🔍 Inspect the deploy log: https://app.netlify.com/sites/business-assistant/deploys/61ae107fdef3b000074dd5d8 😎 Browse the preview: https://deploy-preview-20--business-assistant.netlify.app |
AndersSpringborg
approved these changes
Dec 7, 2021
AndersSpringborg
left a comment
AndersSpringborg
left a comment
Member
There was a problem hiding this comment.
Very nice. Det var da overhovedet ikke dårlig kode 👍🏼 🥇 🍆
| } | ||
|
|
||
| export function tableRowDisplay(registrations: registration[]): tableRow[] { | ||
| console.log(registrations); |
Member
There was a problem hiding this comment.
Er det en glem log, eller en der skal laves om til vores log ting
Comment on lines
+19
to
21
| export function getRegistrations(): registration[] { | ||
| return []; | ||
| } |
Member
There was a problem hiding this comment.
Suggested change
| export function getRegistrations(): registration[] { | |
| return []; | |
| } |
| export const registrationsState = atom({ | ||
| key: "registrations", | ||
| default: getCategoriesAPICall(), | ||
| default: getRegistrations(), |
Member
There was a problem hiding this comment.
Suggested change
| default: getRegistrations(), | |
| default: [], |
|
|
||
| //const Registrations = useRecoilValue(RegistrationState); | ||
| useEffect(() => { | ||
| console.log(order.id); |
Comment on lines
+10
to
12
| export function getCategoriesAPICall(): CategoryDTO[] { | ||
| return [] as CategoryDTO[]; | ||
| } |
Member
There was a problem hiding this comment.
Suggested change
| export function getCategoriesAPICall(): CategoryDTO[] { | |
| return [] as CategoryDTO[]; | |
| } |
|
|
||
| export const categoriesState = atom({ | ||
| key: "categories", | ||
| default: getCategoriesAPICall(), |
Member
There was a problem hiding this comment.
Suggested change
| default: getCategoriesAPICall(), | |
| default: [], |
kaareHH
approved these changes
Dec 8, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hej. Denne PR tilføjer følgende:
Hvad denne PR IKKE tilføjer:
Bedste hilsner,
Ida og Mads 🎅🏿 🧑🏿🎄