Skip to content

docs(svelte): replace deprecated isLoading with isPending in overview#10990

Merged
TkDodo merged 1 commit into
TanStack:mainfrom
poetryofcode:docs/svelte-fix-isloading-to-ispending
Jun 27, 2026
Merged

docs(svelte): replace deprecated isLoading with isPending in overview#10990
TkDodo merged 1 commit into
TanStack:mainfrom
poetryofcode:docs/svelte-fix-isloading-to-ispending

Conversation

@poetryofcode

@poetryofcode poetryofcode commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

isLoading is a deprecated alias for isPending && isFetching and is scheduled for removal in the next major version. The overview example shows a standard (always-enabled) query, so isPending is the correct flag. All other framework overview docs (React, Vue, Angular, Lit, Preact) already use isPending.

Note: isLoading is intentionally retained in disabling-queries guides where it is the right flag for disabled/lazy queries.

🎯 Changes

✅ Checklist

  • I have followed the steps in the Contributing guide.
  • I have tested this code locally with pnpm run test:pr.

🚀 Release Impact

  • This change affects published code, and I have generated a changeset.
  • This change is docs/CI/dev-only (no release).

Summary by CodeRabbit

  • Documentation
    • Updated the Svelte overview example to use the latest loading-state check in its conditional rendering snippet.

`isLoading` is a deprecated alias for `isPending && isFetching` and is
scheduled for removal in the next major version. The overview example
shows a standard (always-enabled) query, so `isPending` is the correct
flag. All other framework overview docs (React, Vue, Angular, Lit,
Preact) already use `isPending`.

Note: `isLoading` is intentionally retained in disabling-queries guides
where it is the right flag for disabled/lazy queries.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 369efc00-1887-466c-9dbd-0b6143a3cf95

📥 Commits

Reviewing files that changed from the base of the PR and between e6ad3fc and 29b14b8.

📒 Files selected for processing (1)
  • docs/framework/svelte/overview.md

📝 Walkthrough

Walkthrough

The Svelte overview example changes the loading-state condition in the code sample from query.isLoading to query.isPending.

Changes

Svelte overview example

Layer / File(s) Summary
Loading branch condition
docs/framework/svelte/overview.md
The example’s “Loading...” branch now checks query.isPending instead of query.isLoading.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

A bunny hopped by with a page in sight,
“Pending!” it squeaked in the morning light.
No loading lag, just a tidy tune,
A tiny doc tweak beneath the moon.
Hoppity hop, the example feels right 🐇

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly matches the PR’s main change: replacing deprecated isLoading with isPending in the Svelte overview docs.
Description check ✅ Passed The description explains the motivation and scope well, though the checklist and release-impact template items are left unfilled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@TkDodo TkDodo merged commit ac7a42d into TanStack:main Jun 27, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants