test(query-core/hydration): replace 'vi.waitFor' with 'vi.advanceTimersByTimeAsync' and use 'queryKey' helper for infinite query tests#10944
Merged
Conversation
…rsByTimeAsync' and use 'queryKey' helper for infinite query tests
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThe hydration test suite for infinite queries is refactored: tests now use ChangesInfinite query hydration test updates
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
|
View your CI Pipeline Execution ↗ for commit a5b6226
☁️ Nx Cloud last updated this comment at |
Contributor
🚀 Changeset Version Preview1 package(s) bumped directly, 24 bumped as dependents. 🟩 Patch bumps
|
Contributor
size-limit report 📦
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Changes
The infinite query tests in
hydration.test.tsxwrappedprefetchInfiniteQuery/fetchInfiniteQuerycalls invi.waitFor(...)while the suite runs under fake timers (vi.useFakeTimers()).vi.waitForpolls a callback that returns a fresh prefetch promise on every tick, which is the wrong tool under fake timers and made these tests slow.This replaces that pattern with the standard fake-timer flow already used throughout the file.
Changes:
vi.waitFor(() => client.prefetch/fetchInfiniteQuery(...))calls withconst promise = client.prefetch/fetchInfiniteQuery(...)+await vi.advanceTimersByTimeAsync(...)+await promise.sleep(10)in the convertedqueryFns and advance by10(single page) /20(thepages: 2test) so the timer control is deterministic.asyncfrom the convertedqueryFn: ({ pageParam }) => sleep(...).then(...)arrows (they only return a promise).queryKey()helper in these tests for uniqueness and consistency with the rest of the file.No assertions were changed. The whole
hydration.test.tsxsuite (42 tests) passes with no type errors, and the run is noticeably faster after removing thevi.waitForpolling.✅ Checklist
pnpm run test:pr.🚀 Release Impact
Summary by CodeRabbit
Release Notes