Skip to content

fix(ai): infer provider options for media activities #858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AdemBenAbdallah wants to merge 1 commit into
base: main
Choose a base branch
from
+22 −20
Open

fix(ai): infer provider options for media activities #858

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/soft-falcons-summarize.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@tanstack/ai': patch
---

Fix provider-specific model options inference for TTS, transcription, and summarize activities.
9 changes: 5 additions & 4 deletions packages/ai/src/activities/generateSpeech/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,10 +35,11 @@ export const kind = 'tts' as const
/**
* Extract provider options from a TTSAdapter via ~types.
*/
export type TTSProviderOptions<TAdapter> =
TAdapter extends TTSAdapter<any, any>
? TAdapter['~types']['providerOptions']
: object
export type TTSProviderOptions<TAdapter> = TAdapter extends {
'~types': { providerOptions: infer P extends object }
}
? P
: object

// ===========================
// Activity Options Type
Expand Down
9 changes: 5 additions & 4 deletions packages/ai/src/activities/generateTranscription/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,10 +35,11 @@ export const kind = 'transcription' as const
/**
* Extract provider options from a TranscriptionAdapter via ~types.
*/
export type TranscriptionProviderOptions<TAdapter> =
TAdapter extends TranscriptionAdapter<any, any>
? TAdapter['~types']['providerOptions']
: object
export type TranscriptionProviderOptions<TAdapter> = TAdapter extends {
'~types': { providerOptions: infer P extends object }
}
? P
: object

// ===========================
// Activity Options Type
Expand Down
19 changes: 7 additions & 12 deletions packages/ai/src/activities/summarize/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,10 +25,11 @@ export const kind = 'summarize' as const
// ===========================

/** Extract provider options from a SummarizeAdapter via ~types */
export type SummarizeProviderOptions<TAdapter> =
TAdapter extends SummarizeAdapter<any, any>
? TAdapter['~types']['providerOptions']
: object
export type SummarizeProviderOptions<TAdapter> = TAdapter extends {
'~types': { providerOptions: infer P extends object }
}
? P
: object

// ===========================
// Activity Options Type
Expand Down Expand Up @@ -159,18 +160,12 @@ export function summarize<

if (stream) {
return runStreamingSummarize(
options as SummarizeActivityOptions<
SummarizeAdapter<string, object>,
true
>,
options as SummarizeActivityOptions<TAdapter, true>,
) as SummarizeActivityResult<TStream>
}

return runSummarize(
options as SummarizeActivityOptions<
SummarizeAdapter<string, object>,
false
>,
options as SummarizeActivityOptions<TAdapter, false>,
) as SummarizeActivityResult<TStream>
}

Expand Down