fix(timsseek): correct obs_mobility unit + refit supersimpleprediction#66
Merged
Conversation
obs_mobility was computed by adding the percent-of-ref mobility error back to ref_mobility, giving values biased ~50% high. avg_delta_mobs now converts pct -> absolute via ref_mobility/100 before feeding the collector, so obs_mob = ref + abs_delta is dimensionally correct. delta_ms1_ms2_mobility likewise switched to absolute 1/k0 units. Side cleanups in offsets.rs: - weighted_ms1 NaN gate was checking mz_error_ppm only, poisoning the mobility accumulator (or dropping valid mobility) on mismatched NaNs. Now gates each dimension independently. - magic .take(3) on FRAGMENT_TOP_N=7 named as FRAGMENT_OBS_MOB_TOP_N. - renamed shadow mz/mob in with_sorted_offsets to ms1_mob/ms2_mob. supersimpleprediction refit on hela_iccoff_gt20peps (34k IDs, holdout MAPE 1.36% vs prior 1.83% claim) using scripts/refit_mobility.py.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.