Review fixes: align naming conventions across ILRepack integration#67
Open
TomProkop wants to merge 8 commits into
Open
Review fixes: align naming conventions across ILRepack integration#67TomProkop wants to merge 8 commits into
TomProkop wants to merge 8 commits into
Conversation
The exclusion list claimed to skip Microsoft.Xrm.Sdk* (per README and
header comment) but only filtered three exact filenames in practice:
Microsoft.Xrm.Sdk, .Deployment, .Workflow. Any future or third-party
Microsoft.Xrm.Sdk.<x>.dll that ended up in OutDir would be merged into
the plugin assembly and cause runtime version clashes inside the
Dataverse sandbox.
Replace the two specific Deployment/Workflow entries with a
StartsWith('Microsoft.Xrm.Sdk.') prefix check covering all sub-
namespaces. Exact 'Microsoft.Xrm.Sdk' (no trailing dot) stays as its
own entry so the base assembly is still excluded.
Align the public API surface of the dependency-merging feature with
the established naming conventions in this repository:
Targets:
- Worker target (unprefixed, callable): MergeAssemblyDependencies
- Hook targets (private, auto-wired): _TalxisPluginAutoMergeHook,
_TalxisWorkflowActivityAutoMergeHook (unchanged)
Properties:
- Opt-out switch: TalxisSkipAssemblyMerge (TalxisSkip* family,
opt-out polarity, matching TalxisSkipDuplicateGuidValidation etc.)
Files:
- MergePluginDependencies.targets -> MergeAssemblyDependencies.targets
- StubForILRepack.targets -> DisableILRepackAutoMerge.targets
- Remove dead Tasks/StubForILRepack.targets + $(TalxisILRepackStub)
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Bring the pre-existing PDPackage ILRepack integration into the same
convention used across the rest of the repo:
Targets:
- DataverseILRepack (hook with inline logic) → split into
MergePackageAssemblyDependencies (unprefixed worker) +
_TalxisPdPackageAutoMergeHook (private hook)
Properties:
- DataversePackageRunILRepack + SkipPackageILRepack → unified to
TalxisSkipAssemblyMerge (same switch used by Plugin/WorkflowActivity)
- DataversePackageILRepackKeyFile → ILRepackKeyFile (generic, no
Dataverse prefix on a tool-config property)
Documentation:
- Add previously undocumented TalxisSkipDuplicateGuidValidation and
TalxisSkipQuickFindValidation to Solution/README.md
- Add previously undocumented TalxisSkipPcfDependencyValidation and
TalxisIgnoredPcfPrefixes to PDPackage/README.md
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #48 — addresses naming consistency review feedback. Should be merged after (or squashed into) #48.
PR #48 fixes (commit 1)
TalxisMergePluginDependencies→MergeAssemblyDependencies(unprefixed worker convention)TalxisMergePluginDependencies(opt-in) →TalxisSkipAssemblyMerge(opt-out,TalxisSkip*family)MergePluginDependencies.targets→MergeAssemblyDependencies.targetsStubForILRepack.targets→DisableILRepackAutoMerge.targetsTalxisILRepackStubproperty + unused Tasks stub fileRepo-wide consistency (commit 2)
DataverseILRepack→ split intoMergePackageAssemblyDependencies(worker) +_TalxisPdPackageAutoMergeHook(private hook)DataversePackageRunILRepack+SkipPackageILRepack→ unified toTalxisSkipAssemblyMergeDataversePackageILRepackKeyFile→ILRepackKeyFileConvention applied
MergeAssemblyDependencies,ValidateDuplicateGuidsTalxis*/_Talxis*TalxisValidateDuplicateGuids,_TalxisPluginAutoMergeHookTalxisSkip*(opt-out)TalxisSkipAssemblyMerge,TalxisSkipDuplicateGuidValidation<ProjectType><Thing>PluginTargetFramework,ILRepackKeyFile