fix: script library builds twice during solution build#66
Open
zekelinAlex wants to merge 2 commits into
Open
Conversation
…ld of script libraries
TomProkop
added a commit
to metjuperry/tools-devkit-build
that referenced
this pull request
Jun 12, 2026
* feat: upgrade Dataverse tasks to net10 host Move the Dataverse build packages to a net10.0 / MSBuild 18 baseline, register the tasks for the .NET task host, and replace pac.exe process execution with direct SolutionPackagerLib invocation. Remaining blocker: TALXIS.Platform.Metadata.Packaging from TALXIS/platform-metadata#48 and TALXIS#66 is not published on NuGet yet, so this repo cannot switch to the shared package dependency in a shippable way yet. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * fix: log full exception details from SolutionPackager and include System.IO.Packaging dependency - Replace ex.Message with Log.LogErrorFromException(ex, showStackTrace: true) so build logs include the full stack trace and inner-exception chain - Remove ProcessCanvasApps field assignments (not part of PackagerArguments API) - Add System.IO.Packaging.dll from PAC CLI tools as a Private reference so SolutionPackagerLib can locate its transitive dependency at runtime Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * chore: bump PDPackage, ScriptLibrary and Sdk to net10.0 Absorbs the remaining net8.0→net10.0 bumps from PR TALXIS#42 (chore/upgrade-tfm-net10) for full repo-wide alignment. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…ibrary-double-build
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Script library projects were getting built twice when a solution referenced them. Once as a normal project reference, and again through GetScriptLibraryOutputs.
The probe target that pulls script libraries out of the reference list was running too late. By the time it removed them, AssignProjectConfiguration had already snapshotted the references, so the standard build picked them up anyway. Moved the probe to run before AssignProjectConfiguration so the removal actually sticks.
Same fix applied to gen pages.