Auto-generate ImportConfig.xml and order solutions by csproj reference order#63
Open
zekelinAlex wants to merge 3 commits into
Open
Conversation
zekelinAlex
force-pushed
the
users/alexander.zekelin/pdpackage-importconfig-autogen
branch
from
1d93612 to
a5ddae1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#59
#58
ImportConfig.xmlis no longer required. If the file is missing, the build generates a skeleton at$(IntermediateOutputPath)<FolderName>/ImportConfig.xmlbefore MSBuild starts validating it, and rewires@(PdImportConfig)to point at the generated copy. The folder name is picked up fromGetImportPackageDataFolderNameon anyImportExtension-derived class in the project's top-level.csfiles, defaulting toPkgAssets.The solutions list is also derived from the
.csproj. WhenAutoGeneratePdImportConfigis on and the sourceImportConfig.xmlhas no<configsolutionfile>entries, the<solutions>block is built from<PackageReference>items (forpp-solutionNuGets) and<ProjectReference>items, in the order they appear in the project fileIf you ship a hand-written
ImportConfig.xmlwith explicit<configsolutionfile>entries, nothing changes — your file is used as-is and auto-generation is skipped entirely.